Showing 1,193 of 2,859 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

SplayTree.prototype.splay_ = function(key) {
  if (this.isEmpty()) {
    return;
  }
  // Create a dummy node.  The use of the dummy node is a bit
Severity: Major
Found in deps/v8/benchmarks/splay.js and 2 other locations - About 2 days to fix
deps/v8/benchmarks/spinning-balls/splay-tree.js on lines 198..257
deps/v8/tools/splaytree.js on lines 224..283

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 468.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

SplayTree.prototype.splay_ = function(key) {
  if (this.isEmpty()) {
    return;
  }
  // Create a dummy node.  The use of the dummy node is a bit
Severity: Major
Found in deps/v8/benchmarks/spinning-balls/splay-tree.js and 2 other locations - About 2 days to fix
deps/v8/benchmarks/splay.js on lines 293..352
deps/v8/tools/splaytree.js on lines 224..283

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 468.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

SplayTree.prototype.splay_ = function(key) {
  if (this.isEmpty()) {
    return;
  }
  // Create a dummy node.  The use of the dummy node is a bit
Severity: Major
Found in deps/v8/tools/splaytree.js and 2 other locations - About 2 days to fix
deps/v8/benchmarks/spinning-balls/splay-tree.js on lines 198..257
deps/v8/benchmarks/splay.js on lines 293..352

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 468.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File net.js has 1029 lines of code (exceeds 250 allowed). Consider refactoring.
Open

// Copyright Joyent, Inc. and other Node contributors.
//
// Permission is hereby granted, free of charge, to any person obtaining a
// copy of this software and associated documentation files (the
// "Software"), to deal in the Software without restriction, including
Severity: Major
Found in lib/net.js - About 2 days to fix

    File child_process.js has 973 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    // Copyright Joyent, Inc. and other Node contributors.
    //
    // Permission is hereby granted, free of charge, to any person obtaining a
    // copy of this software and associated documentation files (the
    // "Software"), to deal in the Software without restriction, including
    Severity: Major
    Found in lib/child_process.js - About 2 days to fix

      File readline.js has 940 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      // Copyright Joyent, Inc. and other Node contributors.
      //
      // Permission is hereby granted, free of charge, to any person obtaining a
      // copy of this software and associated documentation files (the
      // "Software"), to deal in the Software without restriction, including
      Severity: Major
      Found in lib/readline.js - About 2 days to fix

        File install.js has 896 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        // npm install <pkg> <pkg> <pkg>
        //
        // See doc/install.md for more description
        
        // Managing contexts...
        Severity: Major
        Found in deps/npm/lib/install.js - About 2 days to fix

          Function PlotScriptComposer has 427 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function PlotScriptComposer(kResX, kResY, error_output) {
            // Constants.
            var kV8BinarySuffixes = ["/d8", "/libv8.so"];
            var kStackFrames = 8;             // Stack frames to display in the plot.
          
          
          Severity: Major
          Found in deps/v8/tools/profviz/composer.js - About 2 days to fix

            Function runBlock11 has 419 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              function runBlock11() {
                for (var i = 0; i < 2; i++) {
                  ' .pybfr'.replace(re18, '');
                  ' n.svryqOgaPnapry'.replace(re18, '');
                  ' qg'.replace(re18, '');
            Severity: Major
            Found in deps/v8/benchmarks/regexp.js - About 2 days to fix

              File cmake.py has 837 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              # Copyright (c) 2013 Google Inc. All rights reserved.
              # Use of this source code is governed by a BSD-style license that can be
              # found in the LICENSE file.
              
              """cmake output module
              Severity: Major
              Found in tools/gyp/pylib/gyp/generator/cmake.py - About 2 days to fix

                File MSVSSettings.py has 821 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                # Copyright (c) 2012 Google Inc. All rights reserved.
                # Use of this source code is governed by a BSD-style license that can be
                # found in the LICENSE file.
                
                """Code to validate and convert settings of the Microsoft build tools.
                Severity: Major
                Found in tools/gyp/pylib/gyp/MSVSSettings.py - About 1 day to fix

                  File ll_prof.py has 803 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  #!/usr/bin/env python
                  #
                  # Copyright 2012 the V8 project authors. All rights reserved.
                  # Redistribution and use in source and binary forms, with or without
                  # modification, are permitted provided that the following conditions are
                  Severity: Major
                  Found in deps/v8/tools/ll_prof.py - About 1 day to fix

                    File msvs_emulation.py has 764 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    # Copyright (c) 2012 Google Inc. All rights reserved.
                    # Use of this source code is governed by a BSD-style license that can be
                    # found in the LICENSE file.
                    
                    """
                    Severity: Major
                    Found in tools/gyp/pylib/gyp/msvs_emulation.py - About 1 day to fix

                      Function Sodium has 349 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      var Sodium = (function() {
                        "use strict";
                      
                        var kinds = ["FUNCTION", "OPTIMIZED_FUNCTION", "STUB", "BUILTIN",
                                     "LOAD_IC", "KEYED_LOAD_IC", "CALL_IC", "KEYED_CALL_IC",
                      Severity: Major
                      Found in deps/v8/tools/sodium/sodium.js - About 1 day to fix

                        File android.py has 746 lines of code (exceeds 250 allowed). Consider refactoring.
                        Open

                        # Copyright (c) 2012 Google Inc. All rights reserved.
                        # Use of this source code is governed by a BSD-style license that can be
                        # found in the LICENSE file.
                        
                        # Notes:
                        Severity: Major
                        Found in tools/gyp/pylib/gyp/generator/android.py - About 1 day to fix

                          File buffer.js has 718 lines of code (exceeds 250 allowed). Consider refactoring.
                          Open

                          // Copyright Joyent, Inc. and other Node contributors.
                          //
                          // Permission is hereby granted, free of charge, to any person obtaining a
                          // copy of this software and associated documentation files (the
                          // "Software"), to deal in the Software without restriction, including
                          Severity: Major
                          Found in lib/buffer.js - About 1 day to fix

                            File tickprocessor.js has 713 lines of code (exceeds 250 allowed). Consider refactoring.
                            Open

                            // Copyright 2012 the V8 project authors. All rights reserved.
                            // Redistribution and use in source and binary forms, with or without
                            // modification, are permitted provided that the following conditions are
                            // met:
                            //
                            Severity: Major
                            Found in deps/v8/tools/tickprocessor.js - About 1 day to fix

                              File statetracker.py has 709 lines of code (exceeds 250 allowed). Consider refactoring.
                              Open

                              #!/usr/bin/env python
                              #
                              # Copyright 2007 The Closure Linter Authors. All Rights Reserved.
                              #
                              # Licensed under the Apache License, Version 2.0 (the "License");
                              Severity: Major
                              Found in tools/closure_linter/closure_linter/statetracker.py - About 1 day to fix

                                File xcode.py has 702 lines of code (exceeds 250 allowed). Consider refactoring.
                                Open

                                # Copyright (c) 2012 Google Inc. All rights reserved.
                                # Use of this source code is governed by a BSD-style license that can be
                                # found in the LICENSE file.
                                
                                import filecmp
                                Severity: Major
                                Found in tools/gyp/pylib/gyp/generator/xcode.py - About 1 day to fix

                                  Function DebugResponseDetails has 311 lines of code (exceeds 25 allowed). Consider refactoring.
                                  Open

                                  function DebugResponseDetails(response) {
                                    var details = { text: '', running: false };
                                  
                                    try {
                                      if (!response.success()) {
                                  Severity: Major
                                  Found in deps/v8/src/d8.js - About 1 day to fix
                                    Severity
                                    Category
                                    Status
                                    Source
                                    Language