Sign upLogin

jpmckinney/fastcsv

View on GitHub
Star

Showing 7 of 7 total issues

Method shift has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

  def shift
    # COPY
    # handle headers not based on document content
    if header_row? and @return_headers and
       [Array, String].include? @use_headers.class
Severity: Minor
Found in lib/fastcsv.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method shift has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def shift
    # COPY
    # handle headers not based on document content
    if header_row? and @return_headers and
       [Array, String].include? @use_headers.class
Severity: Minor
Found in lib/fastcsv.rb - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

        return shift if @skip_lines and @skip_lines.match row # was next if @skip_lines and @skip_lines.match parse
    Severity: Major
    Found in lib/fastcsv.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                return self.class::Row.new(Array.new, Array.new)
      Severity: Major
      Found in lib/fastcsv.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                  return Array.new
        Severity: Major
        Found in lib/fastcsv.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                    return add_unconverted_fields(Array.new, Array.new)
          Severity: Major
          Found in lib/fastcsv.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                      return shift # was next
            Severity: Major
            Found in lib/fastcsv.rb - About 30 mins to fix
              Severity
              Category
              Status
              Source
              Language