jquery/jquery

View on GitHub

Showing 157 of 157 total issues

Function val has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    val: function( value ) {
        var hooks, ret, valueIsFunction,
            elem = this[ 0 ];

        if ( !arguments.length ) {
Severity: Minor
Found in src/attributes/val.js - About 1 hr to fix

    Function addCombinator has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function addCombinator( matcher, combinator, base ) {
        var dir = combinator.dir,
            skip = combinator.next,
            key = skip || dir,
            checkNonElements = base && key === "parentNode",
    Severity: Minor
    Found in src/selector.js - About 1 hr to fix

      Function data has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          data: function( key, value ) {
              var i, name, data,
                  elem = this[ 0 ],
                  attrs = elem && elem.attributes;
      
      
      Severity: Minor
      Found in src/data.js - About 1 hr to fix

        Function leverageNative has 44 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function leverageNative( el, type, expectSync ) {
        
            // Missing expectSync indicates a trigger call, which must force setup through jQuery.event.add
            if ( !expectSync ) {
                if ( dataPriv.get( el, type ) === undefined ) {
        Severity: Minor
        Found in src/event.js - About 1 hr to fix

          Function extend has 43 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          jQuery.extend = jQuery.fn.extend = function() {
              var options, name, src, copy, copyIsArray, clone,
                  target = arguments[ 0 ] || {},
                  i = 1,
                  length = arguments.length,
          Severity: Minor
          Found in src/core.js - About 1 hr to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

            if ( document.readyState !== "loading" ) {
            
                // Handle it asynchronously to allow scripts the opportunity to delay ready
                window.setTimeout( jQuery.ready );
            
            
            Severity: Major
            Found in src/core/ready-no-deferred.js and 1 other location - About 1 hr to fix
            src/core/ready.js on lines 69..81

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 69.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

            if ( document.readyState !== "loading" ) {
            
                // Handle it asynchronously to allow scripts the opportunity to delay ready
                window.setTimeout( jQuery.ready );
            
            
            Severity: Major
            Found in src/core/ready.js and 1 other location - About 1 hr to fix
            src/core/ready-no-deferred.js on lines 79..91

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 69.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function makeArchives has 42 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function makeArchives( Release, callback ) {
            
                Release.chdir( Release.dir.repo );
            
                function makeArchive( cdn, files, callback ) {
            Severity: Minor
            Found in build/release/cdn.js - About 1 hr to fix

              Function adjustCSS has 41 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function adjustCSS( elem, prop, valueParts, tween ) {
                  var adjusted, scale,
                      maxIterations = 20,
                      currentValue = tween ?
                          function() {
              Severity: Minor
              Found in src/css/adjustCSS.js - About 1 hr to fix

                Function access has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                var access = function( elems, fn, key, value, chainable, emptyGet, raw ) {
                    var i = 0,
                        len = elems.length,
                        bulk = key == null;
                
                
                Severity: Minor
                Found in src/core/access.js - About 1 hr to fix

                  Function style has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      style: function( elem, name, value, extra ) {
                  
                          // Don't set styles on text and comment nodes
                          if ( !elem || elem.nodeType === 3 || elem.nodeType === 8 || !elem.style ) {
                              return;
                  Severity: Minor
                  Found in src/css.js - About 1 hr to fix

                    Function stop has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        stop: function( type, clearQueue, gotoEnd ) {
                            var stopQueue = function( hooks ) {
                                var stop = hooks.stop;
                                delete hooks.stop;
                                stop( gotoEnd );
                    Severity: Minor
                    Found in src/effects.js - About 1 hr to fix

                      Function on has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      function on( elem, types, selector, data, fn, one ) {
                          var origFn, type;
                      
                          // Types can be a map of types/handlers
                          if ( typeof types === "object" ) {
                      Severity: Minor
                      Found in src/event.js - About 1 hr to fix

                        Function toggleClass has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            toggleClass: function( value, stateVal ) {
                                var type = typeof value,
                                    isValidValue = type === "string" || Array.isArray( value );
                        
                                if ( typeof stateVal === "boolean" && isValidValue ) {
                        Severity: Minor
                        Found in src/attributes/classes.js - About 1 hr to fix

                          Function exports has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                          Open

                          module.exports = function( grunt ) {
                              var fs = require( "fs" ),
                                  requirejs = require( "requirejs" ),
                                  Insight = require( "insight" ),
                                  pkg = require( "../../package.json" ),
                          Severity: Minor
                          Found in build/tasks/build.js - About 1 hr to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function dispatch has 39 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              dispatch: function( nativeEvent ) {
                          
                                  // Make a writable jQuery.Event from the native event object
                                  var event = jQuery.event.fix( nativeEvent );
                          
                          
                          Severity: Minor
                          Found in src/event.js - About 1 hr to fix

                            Function ajaxHandleResponses has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                            function ajaxHandleResponses( s, jqXHR, responses ) {
                            
                                var ct, type, finalDataType, firstDataType,
                                    contents = s.contents,
                                    dataTypes = s.dataTypes;
                            Severity: Minor
                            Found in src/ajax.js - About 1 hr to fix

                              Function mightThrow has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                                              mightThrow = function() {
                                                                  var returned, then;
                              
                                                                  // Support: Promises/A+ section 2.3.3.3.3
                                                                  // https://promisesaplus.com/#point-59
                              Severity: Minor
                              Found in src/deferred.js - About 1 hr to fix

                                Function boxModelAdjustment has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                                Open

                                function boxModelAdjustment( elem, dimension, box, isBorderBox, styles, computedVal ) {
                                    var i = dimension === "width" ? 1 : 0,
                                        extra = 0,
                                        delta = 0;
                                
                                
                                Severity: Minor
                                Found in src/css.js - About 1 hr to fix

                                  Function getWidthOrHeight has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                                  Open

                                  function getWidthOrHeight( elem, dimension, extra ) {
                                  
                                      // Start with computed style
                                      var styles = getStyles( elem ),
                                  
                                  
                                  Severity: Minor
                                  Found in src/css.js - About 1 hr to fix
                                    Severity
                                    Category
                                    Status
                                    Source
                                    Language