jquery/jquery

View on GitHub

Showing 227 of 227 total issues

Function getWidthOrHeight has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function getWidthOrHeight( elem, dimension, extra ) {

    // Start with computed style
    var styles = getStyles( elem ),

Severity: Minor
Found in src/css.js - About 1 hr to fix

    Function setOffset has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        setOffset: function( elem, options, i ) {
            var curPosition, curLeft, curCSSTop, curTop, curOffset, curCSSLeft, calculatePosition,
                position = jQuery.css( elem, "position" ),
                curElem = jQuery( elem ),
                props = {};
    Severity: Minor
    Found in src/offset.js - About 1 hr to fix

      Function ATTR has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              ATTR: function( name, operator, check ) {
                  return function( elem ) {
                      var result = jQuery.attr( elem, name );
      
                      if ( result == null ) {
      Severity: Minor
      Found in src/selector.js - About 1 hr to fix

        Function showHide has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function showHide( elements, show ) {
            var display, elem,
                values = [],
                index = 0,
                length = elements.length;
        Severity: Minor
        Found in src/css/showHide.js - About 1 hr to fix

          Function excluder has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                      const excluder = flag => {
                          let additional;
                          const m = /^(\+|\-|)([\w\/-]+)$/.exec( flag );
                          const exclude = m[ 1 ] === "-";
                          const module = m[ 2 ];
          Severity: Minor
          Found in build/tasks/build.js - About 1 hr to fix

            Function handlers has 33 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                handlers: function( event, handlers ) {
                    var i, handleObj, sel, matchedHandlers, matchedSelectors,
                        handlerQueue = [],
                        delegateCount = handlers.delegateCount,
                        cur = event.target;
            Severity: Minor
            Found in src/event.js - About 1 hr to fix

              Function handler has 32 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      handler: function( event ) {
                          var notAsync, result,
                              saved = dataPriv.get( this, type );
              
                          if ( ( event.isTrigger & 1 ) && this[ type ] ) {
              Severity: Minor
              Found in src/event.js - About 1 hr to fix

                Function param has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                Open

                jQuery.param = function( a, traditional ) {
                    var prefix,
                        s = [],
                        add = function( key, valueOrFunction ) {
                
                
                Severity: Minor
                Found in src/serialize.js - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function setOffset has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                Open

                    setOffset: function( elem, options, i ) {
                        var curPosition, curLeft, curCSSTop, curTop, curOffset, curCSSLeft, calculatePosition,
                            position = jQuery.css( elem, "position" ),
                            curElem = jQuery( elem ),
                            props = {};
                Severity: Minor
                Found in src/offset.js - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function load has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                jQuery.fn.load = function( url, params, callback ) {
                    var selector, type, response,
                        self = this,
                        off = url.indexOf( " " );
                
                
                Severity: Minor
                Found in src/ajax/load.js - About 1 hr to fix

                  Function speed has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  jQuery.speed = function( speed, easing, fn ) {
                      var opt = speed && typeof speed === "object" ? jQuery.extend( {}, speed ) : {
                          complete: fn || !fn && easing ||
                              typeof speed === "function" && speed,
                          duration: speed,
                  Severity: Minor
                  Found in src/effects.js - About 1 hr to fix

                    Function removeClass has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        removeClass: function( value ) {
                            var classes, elem, cur, curValue, clazz, j, finalValue,
                                i = 0;
                    
                            if ( typeof value === "function" ) {
                    Severity: Minor
                    Found in src/attributes/classes.js - About 1 hr to fix

                      Function makeArchive has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          function makeArchive( cdn, files, callback ) {
                              if ( Release.preRelease ) {
                                  console.log( "Skipping archive creation for " + cdn + "; this is a beta release." );
                                  callback();
                                  return;
                      Severity: Minor
                      Found in build/release/cdn.js - About 1 hr to fix

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                if ( typeof value === "function" ) {
                                    return this.each( function( j ) {
                                        jQuery( this ).removeClass( value.call( this, j, getClass( this ) ) );
                                    } );
                                }
                        Severity: Major
                        Found in src/attributes/classes.js and 1 other location - About 1 hr to fix
                        src/attributes/classes.js on lines 27..31

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 59.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                if ( typeof value === "function" ) {
                                    return this.each( function( j ) {
                                        jQuery( this ).addClass( value.call( this, j, getClass( this ) ) );
                                    } );
                                }
                        Severity: Major
                        Found in src/attributes/classes.js and 1 other location - About 1 hr to fix
                        src/attributes/classes.js on lines 64..68

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 59.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            preventDefault: function() {
                                var e = this.originalEvent;
                        
                                this.isDefaultPrevented = returnTrue;
                        
                        
                        Severity: Major
                        Found in src/event.js and 1 other location - About 1 hr to fix
                        src/event.js on lines 667..675

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 59.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            stopPropagation: function() {
                                var e = this.originalEvent;
                        
                                this.isPropagationStopped = returnTrue;
                        
                        
                        Severity: Major
                        Found in src/event.js and 1 other location - About 1 hr to fix
                        src/event.js on lines 658..666

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 59.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Function clone has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            clone: function( elem, dataAndEvents, deepDataAndEvents ) {
                                var i, l, srcElements, destElements,
                                    clone = elem.cloneNode( true ),
                                    inPage = isAttached( elem );
                        
                        
                        Severity: Minor
                        Found in src/manipulation.js - About 1 hr to fix

                          Function finish has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              finish: function( type ) {
                                  if ( type !== false ) {
                                      type = type || "fx";
                                  }
                                  return this.each( function() {
                          Severity: Minor
                          Found in src/effects.js - About 1 hr to fix

                            Function attr has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                attr: function( elem, name, value ) {
                                    var ret, hooks,
                                        nType = elem.nodeType;
                            
                                    // Don't get/set attributes on text, comment and attribute nodes
                            Severity: Minor
                            Found in src/attributes/attr.js - About 1 hr to fix
                              Severity
                              Category
                              Status
                              Source
                              Language