Sign upLogin

jsGiven/jsGiven

View on GitHub
Star
js-given/src/scenarios.js

Summary

Maintainability
F
3 days
Test Coverage

File scenarios.js has 521 lines of code (exceeds 250 allowed). Consider refactoring.
Confirmed

// @flow
import _ from 'lodash';
import functionArguments from 'function-arguments';
import humanize from 'string-humanize';
import stripAnsi from 'strip-ansi';
Severity: Major
Found in js-given/src/scenarios.js - About 1 day to fix

    Function scenarios has 201 lines of code (exceeds 25 allowed). Consider refactoring.
    Confirmed

      scenarios<G: Stage, W: Stage, T: Stage>(
    groupName: string,
    stagesParams: StagesParam<G, W, T>,
    scenariosDescriptions: ScenariosDescriptions<G, W, T>
  ) {
    Severity: Major
    Found in js-given/src/scenarios.js - About 1 day to fix

      Function buildStage has 113 lines of code (exceeds 25 allowed). Consider refactoring.
      Confirmed

        buildStage<T>(tClass: Class<T>, runningScenario: RunningScenario): T {
    // $FlowIgnore
    const tInstance = new tClass();
    const tPrototype = Object.getPrototypeOf(tInstance);
      Severity: Major
      Found in js-given/src/scenarios.js - About 4 hrs to fix

        Function methodName has 72 lines of code (exceeds 25 allowed). Consider refactoring.
        Confirmed

              proxyPrototype[methodName] = function(...args: any[]): any {
        const {
          state,
          steps,
          caseArguments,
        Severity: Major
        Found in js-given/src/scenarios.js - About 2 hrs to fix

          Function getScenarios has 44 lines of code (exceeds 25 allowed). Consider refactoring.
          Confirmed

                function getScenarios(scenarios: {
        [key: string]: ScenarioDescription,
      }): ScenarioDescriptionWithName[] {
        const scenarioDescriptions: ScenarioDescriptionWithName[] = Object.keys(
          scenarios
          Severity: Minor
          Found in js-given/src/scenarios.js - About 1 hr to fix

            Function scenarios has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Confirmed

              scenarios<G: Stage, W: Stage, T: Stage>(
    groupName: string,
    stagesParams: StagesParam<G, W, T>,
    scenariosDescriptions: ScenariosDescriptions<G, W, T>
  ) {
            Severity: Minor
            Found in js-given/src/scenarios.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function scenarioDescriptions has 39 lines of code (exceeds 25 allowed). Consider refactoring.
            Confirmed

                    ).map(scenarioPropertyName => {
          const scenarioDescription: ScenarioDescription =
            scenarios[scenarioPropertyName];
          const { scenarioFunction } = scenarioDescription;
          if (scenarioFunction instanceof Function) {
            Severity: Minor
            Found in js-given/src/scenarios.js - About 1 hr to fix

              Similar blocks of code found in 3 locations. Consider refactoring.
              Wontfix

                stepPassed(
    methodName: string,
    decodedParameters: DecodedParameter[],
    stepTimer: Timer
  ) {
              Severity: Major
              Found in js-given/src/scenarios.js and 2 other locations - About 55 mins to fix
              js-given/src/scenarios.js on lines 414..425
              js-given/src/scenarios.js on lines 427..438

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 54.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Wontfix

                stepFailed(
    methodName: string,
    decodedParameters: DecodedParameter[],
    stepTimer: Timer
  ) {
              Severity: Major
              Found in js-given/src/scenarios.js and 2 other locations - About 55 mins to fix
              js-given/src/scenarios.js on lines 401..412
              js-given/src/scenarios.js on lines 427..438

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 54.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Wontfix

                stepSkipped(
    methodName: string,
    decodedParameters: DecodedParameter[],
    stepTimer: Timer
  ) {
              Severity: Major
              Found in js-given/src/scenarios.js and 2 other locations - About 55 mins to fix
              js-given/src/scenarios.js on lines 401..412
              js-given/src/scenarios.js on lines 414..425

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 54.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Wontfix

                addGivenPart() {
    this.currentPart = new ScenarioPart('GIVEN');
    this.currentCase.parts.push(this.currentPart);
  }
              Severity: Minor
              Found in js-given/src/scenarios.js and 2 other locations - About 35 mins to fix
              js-given/src/scenarios.js on lines 391..394
              js-given/src/scenarios.js on lines 396..399

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Wontfix

                addThenPart() {
    this.currentPart = new ScenarioPart('THEN');
    this.currentCase.parts.push(this.currentPart);
  }
              Severity: Minor
              Found in js-given/src/scenarios.js and 2 other locations - About 35 mins to fix
              js-given/src/scenarios.js on lines 386..389
              js-given/src/scenarios.js on lines 391..394

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Wontfix

                addWhenPart() {
    this.currentPart = new ScenarioPart('WHEN');
    this.currentCase.parts.push(this.currentPart);
  }
              Severity: Minor
              Found in js-given/src/scenarios.js and 2 other locations - About 35 mins to fix
              js-given/src/scenarios.js on lines 386..389
              js-given/src/scenarios.js on lines 396..399

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status