juice-shop/juice-shop

View on GitHub

Showing 24 of 152 total issues

Avoid too many return statements within this function.
Open

  return { enabled: true, disabledBecause: null }
Severity: Major
Found in lib/utils.ts - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

        return { enabled: false, disabledBecause: 'Safety Mode' }
    Severity: Major
    Found in lib/utils.ts - About 30 mins to fix

      Function customizeApplication has a Cognitive Complexity of 8 (exceeds 7 allowed). Consider refactoring.
      Open

      const customizeApplication = async () => {
        if (config.get<string>('application.name')) {
          customizeTitle()
        }
        if (config.get('application.logo')) {
      Severity: Minor
      Found in lib/startup/customizeApplication.ts - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function validateConfig has a Cognitive Complexity of 8 (exceeds 7 allowed). Consider refactoring.
      Open

      const validateConfig = async ({ products, memories, exitOnFailure = true }: { products?: ProductConfig[], memories?: MemoryConfig[], exitOnFailure: boolean }) => {
        products = products ?? config.get('products') ?? []
        memories = memories ?? config.get('memories') ?? []
      
        let success = true
      Severity: Minor
      Found in lib/startup/validateConfig.ts - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language