juice-shop/juice-shop

View on GitHub

Showing 152 of 152 total issues

Avoid too many return statements within this function.
Open

  return { enabled: true, disabledBecause: null }
Severity: Major
Found in lib/utils.ts - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

        return { enabled: false, disabledBecause: 'Safety Mode' }
    Severity: Major
    Found in lib/utils.ts - About 30 mins to fix

      Function customizeApplication has a Cognitive Complexity of 8 (exceeds 7 allowed). Consider refactoring.
      Open

      const customizeApplication = async () => {
        if (config.get<string>('application.name')) {
          customizeTitle()
        }
        if (config.get('application.logo')) {
      Severity: Minor
      Found in lib/startup/customizeApplication.ts - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function validateConfig has a Cognitive Complexity of 8 (exceeds 7 allowed). Consider refactoring.
      Open

      const validateConfig = async ({ products, memories, exitOnFailure = true }: { products?: ProductConfig[], memories?: MemoryConfig[], exitOnFailure: boolean }) => {
        products = products ?? config.get('products') ?? []
        memories = memories ?? config.get('memories') ?? []
      
        let success = true
      Severity: Minor
      Found in lib/startup/validateConfig.ts - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      TODO found
      Open

            on('before:browser:launch', (browser: any = {}, launchOptions: any) => { // TODO Remove after upgrade to Cypress >=12.5.0 <or> Chrome 119 become available on GitHub Workflows, see https://github.com/cypress-io/cypress-documentation/issues/5479
      Severity: Minor
      Found in cypress.config.ts by fixme

      TODO found
      Open

            } catch (err: any) { // TODO: Remove any
      Severity: Minor
      Found in routes/fileUpload.ts by fixme

      FIXME found
      Open

        xit('should notify about user login after 2FA verification', () => { // FIXME Spy call is not registered at all

      FIXME found
      Open

          // FIXME warnings below this line need to be checked and fixed.
      Severity: Minor
      Found in frontend/.eslintrc.js by fixme

      FIXME found
      Open

          // @ts-expect-error FIXME promise return handling broken
      Severity: Minor
      Found in test/api/2faSpec.ts by fixme

      FIXME found
      Open

          xit('for 7MS configuration (https://pastebin.com/8SMbWPxc)', () => { // FIXME Test would need to confirm/bypass PasteBin SMART filter to retrieve content
      Severity: Minor
      Found in test/api/internetResourcesSpec.ts by fixme

      FIXME found
      Open

          // @ts-expect-error FIXME any type issue
      Severity: Minor
      Found in lib/startup/validateConfig.ts by fixme

      TODO found
      Open

              uses: dawidd6/action-get-tag@727a6f0a561be04e09013531e73a3983a65e3479 #v1.1.0 TODO Action is archived and should be replaced eventually
      Severity: Minor
      Found in .github/workflows/release.yml by fixme

      FIXME found
      Open

        // @ts-expect-error FIXME promise return handling broken
      Severity: Minor
      Found in test/api/2faSpec.ts by fixme

      FIXME found
      Open

          // @ts-expect-error FIXME promise return handling broken
      Severity: Minor
      Found in test/api/2faSpec.ts by fixme

      FIXME found
      Open

          // @ts-expect-error FIXME form.getHeaders() is not found
      Severity: Minor
      Found in test/api/fileUploadSpec.ts by fixme

      FIXME found
      Open

          // @ts-expect-error FIXME form.getHeaders() is not found
      Severity: Minor
      Found in test/api/fileUploadSpec.ts by fixme

      FIXME found
      Open

            // @ts-expect-error FIXME unclean usage of any type as index
      Severity: Minor
      Found in routes/chatbot.ts by fixme

      FIXME found
      Open

            // @ts-expect-error FIXME form.getHeaders() is not found
      Severity: Minor
      Found in test/api/userProfileSpec.ts by fixme

      TODO found
      Open

        xit('GET quantity of all items for accounting users from IP 123.456.789', () => { // TODO Check if possible to set IP in frisby tests
      Severity: Minor
      Found in test/api/quantityApiSpec.ts by fixme

      FIXME found
      Open

          // @ts-expect-error FIXME promise return handling broken
      Severity: Minor
      Found in test/api/2faSpec.ts by fixme
      Severity
      Category
      Status
      Source
      Language