Sign upLogin

kai-jacobsen/kontentblocks

View on GitHub
Star
core/Ajax/AbstractAjaxResponse.php

Summary

Maintainability
A
0 mins
Test Coverage

The method __construct has a boolean flag argument $send, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function __construct($message = '', $data = array(), $send = true)
Severity: Minor
Found in core/Ajax/AbstractAjaxResponse.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method __construct uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            return $this;
        }
Severity: Minor
Found in core/Ajax/AbstractAjaxResponse.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The 'getStatus()' method which returns a boolean should be named 'is...()' or 'has...()'
Open

    abstract public function getStatus();
Severity: Minor
Found in core/Ajax/AbstractAjaxResponse.php by phpmd

BooleanGetMethodName

Since: 0.2

Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

Example

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

Source https://phpmd.org/rules/naming.html#booleangetmethodname

There are no issues that match your filters.

Category
Status