Sign upLogin

kai-jacobsen/kontentblocks

View on GitHub
Star
core/Ajax/Actions/Autosave.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method action has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected static function action(Request $request)
    {
        $data = wp_unslash($request->request->get('data')); // remove slashes from ajax
        $postEnvironment = Utilities::getPostEnvironment($data['post_ID']);
Severity: Minor
Found in core/Ajax/Actions/Autosave.php - About 1 hr to fix

    Function action has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        protected static function action(Request $request)
    {
        $data = wp_unslash($request->request->get('data')); // remove slashes from ajax
        $postEnvironment = Utilities::getPostEnvironment($data['post_ID']);
    Severity: Minor
    Found in core/Ajax/Actions/Autosave.php - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid using static access to class '\Kontentblocks\Utils\Utilities' in method 'action'.
    Open

            $postEnvironment = Utilities::getPostEnvironment($data['post_ID']);
    Severity: Minor
    Found in core/Ajax/Actions/Autosave.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    There are no issues that match your filters.

    Category
    Status