Sign upLogin

kai-jacobsen/kontentblocks

View on GitHub
Star
core/Ajax/Actions/DeleteModuleViewTemplate.php

Summary

Maintainability
A
1 hr
Test Coverage

Method action has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected static function action(Request $request)
    {
        $module = wp_unslash($request->request->get('module'));
        $view = wp_unslash($request->request->get('view', ''));
        $environment = Utilities::getPostEnvironment($module['postId']);
Severity: Minor
Found in core/Ajax/Actions/DeleteModuleViewTemplate.php - About 1 hr to fix

    Avoid using static access to class '\Kontentblocks\Utils\Utilities' in method 'action'.
    Open

            $environment = Utilities::getPostEnvironment($module['postId']);
    Severity: Minor
    Found in core/Ajax/Actions/DeleteModuleViewTemplate.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid variables with short names like $id. Configured minimum length is 3.
    Open

            $id = $View->id;
    Severity: Minor
    Found in core/Ajax/Actions/DeleteModuleViewTemplate.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    The variable $View is not named in camelCase.
    Open

        protected static function action(Request $request)
    {
        $module = wp_unslash($request->request->get('module'));
        $view = wp_unslash($request->request->get('view', ''));
        $environment = Utilities::getPostEnvironment($module['postId']);
    Severity: Minor
    Found in core/Ajax/Actions/DeleteModuleViewTemplate.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $ModuleWorkshop is not named in camelCase.
    Open

        protected static function action(Request $request)
    {
        $module = wp_unslash($request->request->get('module'));
        $view = wp_unslash($request->request->get('view', ''));
        $environment = Utilities::getPostEnvironment($module['postId']);
    Severity: Minor
    Found in core/Ajax/Actions/DeleteModuleViewTemplate.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $View is not named in camelCase.
    Open

        protected static function action(Request $request)
    {
        $module = wp_unslash($request->request->get('module'));
        $view = wp_unslash($request->request->get('view', ''));
        $environment = Utilities::getPostEnvironment($module['postId']);
    Severity: Minor
    Found in core/Ajax/Actions/DeleteModuleViewTemplate.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $Module is not named in camelCase.
    Open

        protected static function action(Request $request)
    {
        $module = wp_unslash($request->request->get('module'));
        $view = wp_unslash($request->request->get('view', ''));
        $environment = Utilities::getPostEnvironment($module['postId']);
    Severity: Minor
    Found in core/Ajax/Actions/DeleteModuleViewTemplate.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $Module is not named in camelCase.
    Open

        protected static function action(Request $request)
    {
        $module = wp_unslash($request->request->get('module'));
        $view = wp_unslash($request->request->get('view', ''));
        $environment = Utilities::getPostEnvironment($module['postId']);
    Severity: Minor
    Found in core/Ajax/Actions/DeleteModuleViewTemplate.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $View is not named in camelCase.
    Open

        protected static function action(Request $request)
    {
        $module = wp_unslash($request->request->get('module'));
        $view = wp_unslash($request->request->get('view', ''));
        $environment = Utilities::getPostEnvironment($module['postId']);
    Severity: Minor
    Found in core/Ajax/Actions/DeleteModuleViewTemplate.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $View is not named in camelCase.
    Open

        protected static function action(Request $request)
    {
        $module = wp_unslash($request->request->get('module'));
        $view = wp_unslash($request->request->get('view', ''));
        $environment = Utilities::getPostEnvironment($module['postId']);
    Severity: Minor
    Found in core/Ajax/Actions/DeleteModuleViewTemplate.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $ModuleWorkshop is not named in camelCase.
    Open

        protected static function action(Request $request)
    {
        $module = wp_unslash($request->request->get('module'));
        $view = wp_unslash($request->request->get('view', ''));
        $environment = Utilities::getPostEnvironment($module['postId']);
    Severity: Minor
    Found in core/Ajax/Actions/DeleteModuleViewTemplate.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $View is not named in camelCase.
    Open

        protected static function action(Request $request)
    {
        $module = wp_unslash($request->request->get('module'));
        $view = wp_unslash($request->request->get('view', ''));
        $environment = Utilities::getPostEnvironment($module['postId']);
    Severity: Minor
    Found in core/Ajax/Actions/DeleteModuleViewTemplate.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $View is not named in camelCase.
    Open

        protected static function action(Request $request)
    {
        $module = wp_unslash($request->request->get('module'));
        $view = wp_unslash($request->request->get('view', ''));
        $environment = Utilities::getPostEnvironment($module['postId']);
    Severity: Minor
    Found in core/Ajax/Actions/DeleteModuleViewTemplate.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $Module is not named in camelCase.
    Open

        protected static function action(Request $request)
    {
        $module = wp_unslash($request->request->get('module'));
        $view = wp_unslash($request->request->get('view', ''));
        $environment = Utilities::getPostEnvironment($module['postId']);
    Severity: Minor
    Found in core/Ajax/Actions/DeleteModuleViewTemplate.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $Module is not named in camelCase.
    Open

        protected static function action(Request $request)
    {
        $module = wp_unslash($request->request->get('module'));
        $view = wp_unslash($request->request->get('view', ''));
        $environment = Utilities::getPostEnvironment($module['postId']);
    Severity: Minor
    Found in core/Ajax/Actions/DeleteModuleViewTemplate.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $View is not named in camelCase.
    Open

        protected static function action(Request $request)
    {
        $module = wp_unslash($request->request->get('module'));
        $view = wp_unslash($request->request->get('view', ''));
        $environment = Utilities::getPostEnvironment($module['postId']);
    Severity: Minor
    Found in core/Ajax/Actions/DeleteModuleViewTemplate.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $View is not named in camelCase.
    Open

        protected static function action(Request $request)
    {
        $module = wp_unslash($request->request->get('module'));
        $view = wp_unslash($request->request->get('view', ''));
        $environment = Utilities::getPostEnvironment($module['postId']);
    Severity: Minor
    Found in core/Ajax/Actions/DeleteModuleViewTemplate.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $View is not named in camelCase.
    Open

        protected static function action(Request $request)
    {
        $module = wp_unslash($request->request->get('module'));
        $view = wp_unslash($request->request->get('view', ''));
        $environment = Utilities::getPostEnvironment($module['postId']);
    Severity: Minor
    Found in core/Ajax/Actions/DeleteModuleViewTemplate.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    There are no issues that match your filters.

    Category
    Status