Sign upLogin

kai-jacobsen/kontentblocks

View on GitHub
Star
core/Backend/Environment/PostEnvironment.php

Summary

Maintainability
A
2 hrs
Test Coverage

PostEnvironment has 21 functions (exceeds 20 allowed). Consider refactoring.
Open

class PostEnvironment implements JsonSerializable, EnvironmentInterface
{

    /**
     * generic low-level data handler
Severity: Minor
Found in core/Backend/Environment/PostEnvironment.php - About 2 hrs to fix

    Avoid using static access to class '\Kontentblocks\Kontentblocks' in method 'findAreas'.
    Open

            $areaRegistry = Kontentblocks::getService('registry.areas');
    Severity: Minor
    Found in core/Backend/Environment/PostEnvironment.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    The method getPostType uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

                } else {
                $this->postType = get_post_type($this->storageId);
            }
    Severity: Minor
    Found in core/Backend/Environment/PostEnvironment.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid using static access to class '\Kontentblocks\Backend\DataProvider\DataProviderService' in method 'setupAreas'.
    Open

                    DataProviderService::getPostProvider($this->postObj->ID)));
    Severity: Minor
    Found in core/Backend/Environment/PostEnvironment.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    The method getAreaDefinition uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

            } else {
            return false;
        }
    Severity: Minor
    Found in core/Backend/Environment/PostEnvironment.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    There are no issues that match your filters.

    Category
    Status