core/Extensions/OSAdminBar.php
Avoid unused local variables such as '$check'. Open
Open
$check = false;- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
Avoid using static access to class '\Kontentblocks\Language\I18n' in method 'toolbar_edit_control'. Open
Open
$i18n = \Kontentblocks\Language\I18n::getPackage('Extensions.adminBar');- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
The parameter $wp_admin_bar is not named in camelCase. Open
Open
function toolbar_edit_control( $wp_admin_bar ) {
$i18n = \Kontentblocks\Language\I18n::getPackage('Extensions.adminBar');
$args = array(- Read upRead up
- Exclude checks
CamelCaseParameterName
Since: 0.2
It is considered best practice to use the camelCase notation to name parameters.
Example
class ClassName {
public function doSomething($user_name) {
}
}Source
The variable $wp_admin_bar is not named in camelCase. Open
Open
function toolbar_edit_control( $wp_admin_bar ) {
$i18n = \Kontentblocks\Language\I18n::getPackage('Extensions.adminBar');
$args = array(- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}