kai-jacobsen/kontentblocks

View on GitHub
core/Fields/Definitions/SidebarSelect.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid excessively long variable names like $wp_registered_sidebars. Keep variable name length under 20.
Open

        global $wp_registered_sidebars;

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

The variable $wp_registered_sidebars is not named in camelCase.
Open

    public function prepareTemplateData( $data )
    {
        global $wp_registered_sidebars;
        $data['sidebars'] = $wp_registered_sidebars;
        return $data;

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $wp_registered_sidebars is not named in camelCase.
Open

    public function prepareTemplateData( $data )
    {
        global $wp_registered_sidebars;
        $data['sidebars'] = $wp_registered_sidebars;
        return $data;

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

There are no issues that match your filters.

Category
Status