Sign upLogin

kai-jacobsen/kontentblocks

View on GitHub
Star
core/Fields/FieldRegistry.php

Summary

Maintainability
A
1 hr
Test Coverage

Function add has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    public function add($file)
    {
        include_once($file);
        $classname = '\Kontentblocks\Fields\Definitions\\' . str_replace('.php', '', basename($file));
Severity: Minor
Found in core/Fields/FieldRegistry.php - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getField has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function getField($type, $baseId, $subkey, $key, $args = array())
Severity: Minor
Found in core/Fields/FieldRegistry.php - About 35 mins to fix

    Missing class import via use statement (line '47', column '23').
    Open

                throw new \Exception('Field MUST extend Kontentblocks Field Class');
    Severity: Minor
    Found in core/Fields/FieldRegistry.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    There are no issues that match your filters.

    Category
    Status