kai-jacobsen/kontentblocks

View on GitHub
core/Hooks/Enqueues.php

Summary

Maintainability
C
1 day
Test Coverage

Function localize has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

    private static function localize()
    {
        //Caps for the current user as global js object

        $current_user = wp_get_current_user();
Severity: Minor
Found in core/Hooks/Enqueues.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

The class Enqueues has an overall complexity of 56 which is very high. The configured complexity threshold is 50.
Open

class Enqueues
{

    protected static $styles;
    protected static $adminScripts = array();
Severity: Minor
Found in core/Hooks/Enqueues.php by phpmd

Method registerScripts has 82 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function registerScripts()
    {
        $folder = (defined('SCRIPT_DEBUG') && SCRIPT_DEBUG) ? 'dev' : 'dist';
        $suffix = (defined('SCRIPT_DEBUG') && SCRIPT_DEBUG) ? '' : '.min';
        $version = Kontentblocks::VERSION;
Severity: Major
Found in core/Hooks/Enqueues.php - About 3 hrs to fix

    File Enqueues.php has 300 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    
    namespace Kontentblocks\Hooks;
    
    use Kontentblocks\Kontentblocks;
    Severity: Minor
    Found in core/Hooks/Enqueues.php - About 3 hrs to fix

      Method localize has 48 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private static function localize()
          {
              //Caps for the current user as global js object
      
              $current_user = wp_get_current_user();
      Severity: Minor
      Found in core/Hooks/Enqueues.php - About 1 hr to fix

        Function addScript has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public static function addScript($args, $where = 'both')
            {
                $defaults = array(
                    'handle' => null,
                    'src' => null,
        Severity: Minor
        Found in core/Hooks/Enqueues.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        The method registerScripts() has 103 lines of code. Current threshold is set to 100. Avoid really long methods.
        Open

            public static function registerScripts()
            {
                $folder = (defined('SCRIPT_DEBUG') && SCRIPT_DEBUG) ? 'dev' : 'dist';
                $suffix = (defined('SCRIPT_DEBUG') && SCRIPT_DEBUG) ? '' : '.min';
                $version = Kontentblocks::VERSION;
        Severity: Minor
        Found in core/Hooks/Enqueues.php by phpmd

        The method localize() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
        Open

            private static function localize()
            {
                //Caps for the current user as global js object
        
                $current_user = wp_get_current_user();
        Severity: Minor
        Found in core/Hooks/Enqueues.php by phpmd

        CyclomaticComplexity

        Since: 0.1

        Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

        Example

        // Cyclomatic Complexity = 11
        class Foo {
        1   public function example() {
        2       if ($a == $b) {
        3           if ($a1 == $b1) {
                        fiddle();
        4           } elseif ($a2 == $b2) {
                        fiddle();
                    } else {
                        fiddle();
                    }
        5       } elseif ($c == $d) {
        6           while ($c == $d) {
                        fiddle();
                    }
        7        } elseif ($e == $f) {
        8           for ($n = 0; $n < $h; $n++) {
                        fiddle();
                    }
                } else {
                    switch ($z) {
        9               case 1:
                            fiddle();
                            break;
        10              case 2:
                            fiddle();
                            break;
        11              case 3:
                            fiddle();
                            break;
                        default:
                            fiddle();
                            break;
                    }
                }
            }
        }

        Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

        Avoid using static access to class 'Kontentblocks\Hooks\Capabilities' in method 'localize'.
        Open

                $setup_caps = (!empty($option)) ? $option : Capabilities::defaultCapabilities();
        Severity: Minor
        Found in core/Hooks/Enqueues.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
        {
            public function bar()
            {
                Bar::baz();
            }
        }

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Avoid using static access to class '\Kontentblocks\Utils\Utilities' in method 'userEnqueue'.
        Open

                    Utilities::hiddenEditor();
        Severity: Minor
        Found in core/Hooks/Enqueues.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
        {
            public function bar()
            {
                Bar::baz();
            }
        }

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Avoid unused local variables such as '$is_IE'.
        Open

                global $is_IE;
        Severity: Minor
        Found in core/Hooks/Enqueues.php by phpmd

        UnusedLocalVariable

        Since: 0.2

        Detects when a local variable is declared and/or assigned, but not used.

        Example

        class Foo {
            public function doSomething()
            {
                $i = 5; // Unused
            }
        }

        Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

        The variable $colorpicker_l10n is not named in camelCase.
        Open

            public static function userEnqueue()
            {
                self::appConfig();
        
                if (!apply_filters('kb.enqueue.frontend.scripts', true)) {
        Severity: Minor
        Found in core/Hooks/Enqueues.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
            public function doSomething() {
                $data_module = new DataModule();
            }
        }

        Source

        The variable $setup_caps is not named in camelCase.
        Open

            private static function localize()
            {
                //Caps for the current user as global js object
        
                $current_user = wp_get_current_user();
        Severity: Minor
        Found in core/Hooks/Enqueues.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
            public function doSomething() {
                $data_module = new DataModule();
            }
        }

        Source

        The variable $setup_caps is not named in camelCase.
        Open

            private static function localize()
            {
                //Caps for the current user as global js object
        
                $current_user = wp_get_current_user();
        Severity: Minor
        Found in core/Hooks/Enqueues.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
            public function doSomething() {
                $data_module = new DataModule();
            }
        }

        Source

        The variable $setup_caps is not named in camelCase.
        Open

            private static function localize()
            {
                //Caps for the current user as global js object
        
                $current_user = wp_get_current_user();
        Severity: Minor
        Found in core/Hooks/Enqueues.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
            public function doSomething() {
                $data_module = new DataModule();
            }
        }

        Source

        The variable $wp_version is not named in camelCase.
        Open

            public static function appConfig()
            {
                global $post, $wp_version;
                $screen = (function_exists('get_current_screen')) ? get_current_screen() : null;
                $data = array(
        Severity: Minor
        Found in core/Hooks/Enqueues.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
            public function doSomething() {
                $data_module = new DataModule();
            }
        }

        Source

        The variable $setup_caps is not named in camelCase.
        Open

            private static function localize()
            {
                //Caps for the current user as global js object
        
                $current_user = wp_get_current_user();
        Severity: Minor
        Found in core/Hooks/Enqueues.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
            public function doSomething() {
                $data_module = new DataModule();
            }
        }

        Source

        The variable $colorpicker_l10n is not named in camelCase.
        Open

            public static function userEnqueue()
            {
                self::appConfig();
        
                if (!apply_filters('kb.enqueue.frontend.scripts', true)) {
        Severity: Minor
        Found in core/Hooks/Enqueues.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
            public function doSomething() {
                $data_module = new DataModule();
            }
        }

        Source

        The variable $is_IE is not named in camelCase.
        Open

            public static function adminEnqueue()
            {
                global $is_IE;
        
                self::appConfig();
        Severity: Minor
        Found in core/Hooks/Enqueues.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
            public function doSomething() {
                $data_module = new DataModule();
            }
        }

        Source

        The variable $wp_version is not named in camelCase.
        Open

            public static function appConfig()
            {
                global $post, $wp_version;
                $screen = (function_exists('get_current_screen')) ? get_current_screen() : null;
                $data = array(
        Severity: Minor
        Found in core/Hooks/Enqueues.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
            public function doSomething() {
                $data_module = new DataModule();
            }
        }

        Source

        The variable $setup_caps is not named in camelCase.
        Open

            private static function localize()
            {
                //Caps for the current user as global js object
        
                $current_user = wp_get_current_user();
        Severity: Minor
        Found in core/Hooks/Enqueues.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
            public function doSomething() {
                $data_module = new DataModule();
            }
        }

        Source

        The variable $current_user is not named in camelCase.
        Open

            private static function localize()
            {
                //Caps for the current user as global js object
        
                $current_user = wp_get_current_user();
        Severity: Minor
        Found in core/Hooks/Enqueues.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
            public function doSomething() {
                $data_module = new DataModule();
            }
        }

        Source

        The variable $current_user is not named in camelCase.
        Open

            private static function localize()
            {
                //Caps for the current user as global js object
        
                $current_user = wp_get_current_user();
        Severity: Minor
        Found in core/Hooks/Enqueues.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
            public function doSomething() {
                $data_module = new DataModule();
            }
        }

        Source

        The variable $setup_caps is not named in camelCase.
        Open

            private static function localize()
            {
                //Caps for the current user as global js object
        
                $current_user = wp_get_current_user();
        Severity: Minor
        Found in core/Hooks/Enqueues.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
            public function doSomething() {
                $data_module = new DataModule();
            }
        }

        Source

        There are no issues that match your filters.

        Category
        Status