kai-jacobsen/kontentblocks

View on GitHub
core/Templating/Twig.php

Summary

Maintainability
A
0 mins
Test Coverage

Missing class import via use statement (line '37', column '23').
Open

        $loader = new \Twig_Loader_Filesystem($paths);
Severity: Minor
Found in core/Templating/Twig.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method addCustomFunctions has a boolean flag argument $upscale, which is a certain sign of a Single Responsibility Principle violation.
Open

            function ($id, $width = null, $height = null, $crop = true, $single = true, $upscale = true) {
Severity: Minor
Found in core/Templating/Twig.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method setupEnvironment has a boolean flag argument $public, which is a certain sign of a Single Responsibility Principle violation.
Open

    public static function setupEnvironment(Container $services, $public = true)
Severity: Minor
Found in core/Templating/Twig.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method addCustomFunctions has a boolean flag argument $single, which is a certain sign of a Single Responsibility Principle violation.
Open

            function ($id, $width = null, $height = null, $crop = true, $single = true, $upscale = true) {
Severity: Minor
Found in core/Templating/Twig.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method addCustomFunctions has a boolean flag argument $crop, which is a certain sign of a Single Responsibility Principle violation.
Open

            function ($id, $width = null, $height = null, $crop = true, $single = true, $upscale = true) {
Severity: Minor
Found in core/Templating/Twig.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '62', column '28').
Open

        $environment = new \Twig_Environment(
Severity: Minor
Found in core/Templating/Twig.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '124', column '20').
Open

        return new \Twig_SimpleFilter(
Severity: Minor
Found in core/Templating/Twig.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '67', column '40').
Open

        $environment->addExtension(new \Twig_Extension_Debug());
Severity: Minor
Found in core/Templating/Twig.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '102', column '24').
Open

            return new \Twig_SimpleFunction(
Severity: Minor
Found in core/Templating/Twig.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid variables with short names like $id. Configured minimum length is 3.
Open

            function ($id, $width = null, $height = null, $crop = true, $single = true, $upscale = true) {
Severity: Minor
Found in core/Templating/Twig.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

There are no issues that match your filters.

Category
Status