Sign upLogin

kai-jacobsen/kontentblocks

View on GitHub
Star

Showing 4,293 of 4,293 total issues

Method 'factorNewItem' has a complexity of 11.
Open

  factorNewItem: function (data, obj) {
Severity: Minor
Found in js/src/fields/controls/flexfields/FlexFieldsFactory.js by eslint

Limit Cyclomatic Complexity (complexity)

Cyclomatic complexity measures the number of linearly independent paths through a program's source code. This rule allows setting a cyclomatic complexity threshold.

function a(x) {
    if (true) {
        return x; // 1st path
    } else if (false) {
        return x+1; // 2nd path
    } else {
        return 4; // 3rd path
    }
}

Rule Details

This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is 20).

Examples of incorrect code for a maximum of 2:

/*eslint complexity: ["error", 2]*/

function a(x) {
    if (true) {
        return x;
    } else if (false) {
        return x+1;
    } else {
        return 4; // 3rd path
    }
}

Examples of correct code for a maximum of 2:

/*eslint complexity: ["error", 2]*/

function a(x) {
    if (true) {
        return x;
    } else {
        return 4;
    }
}

Options

Optionally, you may specify a max object property:

"complexity": ["error", 2]

is equivalent to

"complexity": ["error", { "max": 2 }]

Deprecated: the object property maximum is deprecated. Please use the property max instead.

When Not To Use It

If you can't determine an appropriate complexity limit for your code, then it's best to disable this rule.

Further Reading

Related Rules

  • [max-depth](max-depth.md)
  • [max-len](max-len.md)
  • [max-nested-callbacks](max-nested-callbacks.md)
  • [max-params](max-params.md)
  • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

Method 'htmlTemplate' has a complexity of 11.
Open

        htmlTemplate: function(r) {
Severity: Minor
Found in js/third-party/leaflet-geocoder.js by eslint

Limit Cyclomatic Complexity (complexity)

Cyclomatic complexity measures the number of linearly independent paths through a program's source code. This rule allows setting a cyclomatic complexity threshold.

function a(x) {
    if (true) {
        return x; // 1st path
    } else if (false) {
        return x+1; // 2nd path
    } else {
        return 4; // 3rd path
    }
}

Rule Details

This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is 20).

Examples of incorrect code for a maximum of 2:

/*eslint complexity: ["error", 2]*/

function a(x) {
    if (true) {
        return x;
    } else if (false) {
        return x+1;
    } else {
        return 4; // 3rd path
    }
}

Examples of correct code for a maximum of 2:

/*eslint complexity: ["error", 2]*/

function a(x) {
    if (true) {
        return x;
    } else {
        return 4;
    }
}

Options

Optionally, you may specify a max object property:

"complexity": ["error", 2]

is equivalent to

"complexity": ["error", { "max": 2 }]

Deprecated: the object property maximum is deprecated. Please use the property max instead.

When Not To Use It

If you can't determine an appropriate complexity limit for your code, then it's best to disable this rule.

Further Reading

Related Rules

  • [max-depth](max-depth.md)
  • [max-len](max-len.md)
  • [max-nested-callbacks](max-nested-callbacks.md)
  • [max-params](max-params.md)
  • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

Function success has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      success: function (res) {
        // clear form content
        that.$inner.empty();
        // clear fields on ModuleView
        that.ModuleView.clearFields();
Severity: Major
Found in js/src/frontend/Views/EditModalModules.js - About 2 hrs to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        public function getFormFilter( $fielddata )
    {
        $collect = array();
        if (!empty( $fielddata )) {
            foreach ($fielddata as $k => $v) {
    Severity: Major
    Found in core/Fields/Definitions/CheckboxSet.php and 1 other location - About 2 hrs to fix
    core/Fields/Definitions/RadioSet.php on lines 55..76

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 126.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        public function getFormFilter($fielddata)
    {
        $collect = array();
        if (!empty($fielddata)) {
            foreach ($fielddata as $k => $v) {
    Severity: Major
    Found in core/Fields/Definitions/RadioSet.php and 1 other location - About 2 hrs to fix
    core/Fields/Definitions/CheckboxSet.php on lines 68..90

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 126.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 4 locations. Consider refactoring.
    Open

      isValid: function () {
    if (!Checks.userCan(this.model.get('settings').cap)){
      return false;
    }
    if (KB.Environment && KB.Environment.postType === "kb-gmd" ){
    Severity: Major
    Found in js/src/shared/ModuleStatusBar/status/LoggedInStatus.js and 3 other locations - About 2 hrs to fix
    js/src/shared/ModuleStatusBar/status/DraftStatus.js on lines 15..25
    js/src/shared/ModuleStatusBar/status/PublishStatus.js on lines 14..24
    js/src/shared/ModuleStatusBar/status/SettingsStatus.js on lines 15..25

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 79.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 4 locations. Consider refactoring.
    Open

      isValid: function () {
    if (!Checks.userCan(this.model.get('settings').cap)){
      return false;
    }
    Severity: Major
    Found in js/src/shared/ModuleStatusBar/status/DraftStatus.js and 3 other locations - About 2 hrs to fix
    js/src/shared/ModuleStatusBar/status/LoggedInStatus.js on lines 13..21
    js/src/shared/ModuleStatusBar/status/PublishStatus.js on lines 14..24
    js/src/shared/ModuleStatusBar/status/SettingsStatus.js on lines 15..25

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 79.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 4 locations. Consider refactoring.
    Open

      isValid: function () {

    if (!Checks.userCan(this.model.get('settings').cap)){
      return false;
    }
    Severity: Major
    Found in js/src/shared/ModuleStatusBar/status/PublishStatus.js and 3 other locations - About 2 hrs to fix
    js/src/shared/ModuleStatusBar/status/DraftStatus.js on lines 15..25
    js/src/shared/ModuleStatusBar/status/LoggedInStatus.js on lines 13..21
    js/src/shared/ModuleStatusBar/status/SettingsStatus.js on lines 15..25

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 79.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 4 locations. Consider refactoring.
    Open

      isValid: function () {

    if (!Checks.userCan(this.model.get('settings').cap)){
      return false;
    }
    Severity: Major
    Found in js/src/shared/ModuleStatusBar/status/SettingsStatus.js and 3 other locations - About 2 hrs to fix
    js/src/shared/ModuleStatusBar/status/DraftStatus.js on lines 15..25
    js/src/shared/ModuleStatusBar/status/LoggedInStatus.js on lines 13..21
    js/src/shared/ModuleStatusBar/status/PublishStatus.js on lines 14..24

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 79.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Kontentblocks has 21 functions (exceeds 20 allowed). Consider refactoring.
    Open

    Class Kontentblocks
{

    const VERSION = '0.12.3';
    const DEVMODE = true;
    Severity: Minor
    Found in kontentblocks.php - About 2 hrs to fix

      ModuleStorage has 21 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class ModuleStorage implements \Countable
{
    /**
     * current post id
     * @var int
      Severity: Minor
      Found in core/Backend/Storage/ModuleStorage.php - About 2 hrs to fix

        AreaRegistry has 21 functions (exceeds 20 allowed). Consider refactoring.
        Open

        class AreaRegistry
{

    /**
     * All register areas
        Severity: Minor
        Found in core/Areas/AreaRegistry.php - About 2 hrs to fix

          PostEnvironment has 21 functions (exceeds 20 allowed). Consider refactoring.
          Open

          class PostEnvironment implements JsonSerializable, EnvironmentInterface
{

    /**
     * generic low-level data handler
          Severity: Minor
          Found in core/Backend/Environment/PostEnvironment.php - About 2 hrs to fix

            Function openFrame has 54 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              openFrame: function (editmode) {
    var that = this, metadata, frameoptions;
    if (this.frame) {
      this.frame.dispose();
    }
            Severity: Major
            Found in js/src/fields/controls/cropimage.js - About 2 hrs to fix

              Function openFrame has 54 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                openFrame: function (editmode) {
    var that = this, metadata;
    if (this.frame) {
      this.frame.dispose();
    }
              Severity: Major
              Found in js/src/fields/controls/image.js - About 2 hrs to fix

                Method markVisibility has 54 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function markVisibility(Field $field)
    {

        $field->setVisibility(true);
        $areaContext = $this->entity->getContext()->get('areaContext');
                Severity: Major
                Found in core/Fields/ModuleFieldSection.php - About 2 hrs to fix

                  Similar blocks of code found in 6 locations. Consider refactoring.
                  Open

                    mouseleave: function(){
    this.Parent.$el.removeClass('kb-field--outline');
    _.each(this.model.get('linkedFields'), function(linkedModel){
      linkedModel.FieldControlView.$el.removeClass('kb-field--outline-link');
    })
                  Severity: Major
                  Found in js/src/frontend/Inline/controls/EditImage.js and 5 other locations - About 2 hrs to fix
                  js/src/frontend/Inline/controls/EditImage.js on lines 24..29
                  js/src/frontend/Inline/controls/EditLink.js on lines 26..31
                  js/src/frontend/Inline/controls/EditLink.js on lines 32..37
                  js/src/frontend/Inline/controls/EditText.js on lines 23..28
                  js/src/frontend/Inline/controls/EditText.js on lines 29..34

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 78.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 6 locations. Consider refactoring.
                  Open

                    mouseenter: function () {
    this.Parent.$el.addClass('kb-field--outline');
    _.each(this.model.get('linkedFields'), function(linkedModel){
      linkedModel.FieldControlView.$el.addClass('kb-field--outline-link');
    })
                  Severity: Major
                  Found in js/src/frontend/Inline/controls/EditLink.js and 5 other locations - About 2 hrs to fix
                  js/src/frontend/Inline/controls/EditImage.js on lines 24..29
                  js/src/frontend/Inline/controls/EditImage.js on lines 30..35
                  js/src/frontend/Inline/controls/EditLink.js on lines 32..37
                  js/src/frontend/Inline/controls/EditText.js on lines 23..28
                  js/src/frontend/Inline/controls/EditText.js on lines 29..34

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 78.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 6 locations. Consider refactoring.
                  Open

                    mouseleave: function(){
    this.Parent.$el.removeClass('kb-field--outline');
    _.each(this.model.get('linkedFields'), function(linkedModel){
      linkedModel.FieldControlView.$el.removeClass('kb-field--outline-link');
    })
                  Severity: Major
                  Found in js/src/frontend/Inline/controls/EditLink.js and 5 other locations - About 2 hrs to fix
                  js/src/frontend/Inline/controls/EditImage.js on lines 24..29
                  js/src/frontend/Inline/controls/EditImage.js on lines 30..35
                  js/src/frontend/Inline/controls/EditLink.js on lines 26..31
                  js/src/frontend/Inline/controls/EditText.js on lines 23..28
                  js/src/frontend/Inline/controls/EditText.js on lines 29..34

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 78.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 6 locations. Consider refactoring.
                  Open

                    mouseenter: function () {
    this.Parent.$el.addClass('kb-field--outline');
    _.each(this.model.get('linkedFields'), function (linkedModel) {
      linkedModel.FieldControlView.$el.addClass('kb-field--outline-link');
    })
                  Severity: Major
                  Found in js/src/frontend/Inline/controls/EditText.js and 5 other locations - About 2 hrs to fix
                  js/src/frontend/Inline/controls/EditImage.js on lines 24..29
                  js/src/frontend/Inline/controls/EditImage.js on lines 30..35
                  js/src/frontend/Inline/controls/EditLink.js on lines 26..31
                  js/src/frontend/Inline/controls/EditLink.js on lines 32..37
                  js/src/frontend/Inline/controls/EditText.js on lines 29..34

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 78.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Severity
                  Category
                  Status
                  Source
                  Language