Sign upLogin

kai-jacobsen/kontentblocks

View on GitHub
Star
js/src/fields/FieldControlModel.js

Summary

Maintainability
A
1 hr
Test Coverage

Function sync has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  sync: function (context) {
    var that = this;
    KB.Events.trigger('field.before.sync', this.model);

    var clone = that.toJSON();
Severity: Minor
Found in js/src/fields/FieldControlModel.js - About 1 hr to fix

    Expected a conditional expression and instead saw an assignment.
    Open

        if (ModuleModel = this.get('ModuleModel')) {
    Severity: Minor
    Found in js/src/fields/FieldControlModel.js by eslint

    disallow assignment operators in conditional statements (no-cond-assign)

    In conditional statements, it is very easy to mistype a comparison operator (such as ==) as an assignment operator (such as =). For example:

    // Check the user's job title
if (user.jobTitle = "manager") {
    // user.jobTitle is now incorrect
}

    There are valid reasons to use assignment operators in conditional statements. However, it can be difficult to tell whether a specific assignment was intentional.

    Rule Details

    This rule disallows ambiguous assignment operators in test conditions of if, for, while, and do...while statements.

    Options

    This rule has a string option:

    • "except-parens" (default) allows assignments in test conditions only if they are enclosed in parentheses (for example, to allow reassigning a variable in the test of a while or do...while loop)
    • "always" disallows all assignments in test conditions

    except-parens

    Examples of incorrect code for this rule with the default "except-parens" option:

    /*eslint no-cond-assign: "error"*/

// Unintentional assignment
var x;
if (x = 0) {
    var b = 1;
}

// Practical example that is similar to an error
function setHeight(someNode) {
    "use strict";
    do {
        someNode.height = "100px";
    } while (someNode = someNode.parentNode);
}

    Examples of correct code for this rule with the default "except-parens" option:

    /*eslint no-cond-assign: "error"*/

// Assignment replaced by comparison
var x;
if (x === 0) {
    var b = 1;
}

// Practical example that wraps the assignment in parentheses
function setHeight(someNode) {
    "use strict";
    do {
        someNode.height = "100px";
    } while ((someNode = someNode.parentNode));
}

// Practical example that wraps the assignment and tests for 'null'
function setHeight(someNode) {
    "use strict";
    do {
        someNode.height = "100px";
    } while ((someNode = someNode.parentNode) !== null);
}

    always

    Examples of incorrect code for this rule with the "always" option:

    /*eslint no-cond-assign: ["error", "always"]*/

// Unintentional assignment
var x;
if (x = 0) {
    var b = 1;
}

// Practical example that is similar to an error
function setHeight(someNode) {
    "use strict";
    do {
        someNode.height = "100px";
    } while (someNode = someNode.parentNode);
}

// Practical example that wraps the assignment in parentheses
function setHeight(someNode) {
    "use strict";
    do {
        someNode.height = "100px";
    } while ((someNode = someNode.parentNode));
}

// Practical example that wraps the assignment and tests for 'null'
function setHeight(someNode) {
    "use strict";
    do {
        someNode.height = "100px";
    } while ((someNode = someNode.parentNode) !== null);
}

    Examples of correct code for this rule with the "always" option:

    /*eslint no-cond-assign: ["error", "always"]*/

// Assignment replaced by comparison
var x;
if (x === 0) {
    var b = 1;
}

    Related Rules

    Expected a conditional expression and instead saw an assignment.
    Open

        if (view = this.getType()) { // obj equals specific field view
    Severity: Minor
    Found in js/src/fields/FieldControlModel.js by eslint

    disallow assignment operators in conditional statements (no-cond-assign)

    In conditional statements, it is very easy to mistype a comparison operator (such as ==) as an assignment operator (such as =). For example:

    // Check the user's job title
if (user.jobTitle = "manager") {
    // user.jobTitle is now incorrect
}

    There are valid reasons to use assignment operators in conditional statements. However, it can be difficult to tell whether a specific assignment was intentional.

    Rule Details

    This rule disallows ambiguous assignment operators in test conditions of if, for, while, and do...while statements.

    Options

    This rule has a string option:

    • "except-parens" (default) allows assignments in test conditions only if they are enclosed in parentheses (for example, to allow reassigning a variable in the test of a while or do...while loop)
    • "always" disallows all assignments in test conditions

    except-parens

    Examples of incorrect code for this rule with the default "except-parens" option:

    /*eslint no-cond-assign: "error"*/

// Unintentional assignment
var x;
if (x = 0) {
    var b = 1;
}

// Practical example that is similar to an error
function setHeight(someNode) {
    "use strict";
    do {
        someNode.height = "100px";
    } while (someNode = someNode.parentNode);
}

    Examples of correct code for this rule with the default "except-parens" option:

    /*eslint no-cond-assign: "error"*/

// Assignment replaced by comparison
var x;
if (x === 0) {
    var b = 1;
}

// Practical example that wraps the assignment in parentheses
function setHeight(someNode) {
    "use strict";
    do {
        someNode.height = "100px";
    } while ((someNode = someNode.parentNode));
}

// Practical example that wraps the assignment and tests for 'null'
function setHeight(someNode) {
    "use strict";
    do {
        someNode.height = "100px";
    } while ((someNode = someNode.parentNode) !== null);
}

    always

    Examples of incorrect code for this rule with the "always" option:

    /*eslint no-cond-assign: ["error", "always"]*/

// Unintentional assignment
var x;
if (x = 0) {
    var b = 1;
}

// Practical example that is similar to an error
function setHeight(someNode) {
    "use strict";
    do {
        someNode.height = "100px";
    } while (someNode = someNode.parentNode);
}

// Practical example that wraps the assignment in parentheses
function setHeight(someNode) {
    "use strict";
    do {
        someNode.height = "100px";
    } while ((someNode = someNode.parentNode));
}

// Practical example that wraps the assignment and tests for 'null'
function setHeight(someNode) {
    "use strict";
    do {
        someNode.height = "100px";
    } while ((someNode = someNode.parentNode) !== null);
}

    Examples of correct code for this rule with the "always" option:

    /*eslint no-cond-assign: ["error", "always"]*/

// Assignment replaced by comparison
var x;
if (x === 0) {
    var b = 1;
}

    Related Rules

    There are no issues that match your filters.

    Category
    Status