Sign upLogin

kai-jacobsen/kontentblocks

View on GitHub
Star
js/src/fields/controls/KB.Plupload.js

Summary

Maintainability
B
6 hrs
Test Coverage

Function init has 77 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  init: function (modalView) {
    if (!wp || !wp.media) {
      return;
    }
Severity: Major
Found in js/src/fields/controls/KB.Plupload.js - About 3 hrs to fix

    Function initialize has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      initialize: function (params) {
    var that = this;
    this.Collection = new KB.Plupload.FileCollection();
    this.FileRenderer = new KB.Plupload.FileRenderer({collection: this.Collection, controller: this});
    this.params = params;
    Severity: Minor
    Found in js/src/fields/controls/KB.Plupload.js - About 1 hr to fix

      unnecessary '.call()'.
      Open

                view.getField(key, arrayKey).bootstrap.call(view.getField(key, arrayKey));
      Severity: Minor
      Found in js/src/fields/controls/KB.Plupload.js by eslint

      Disallow unnecessary .call() and .apply(). (no-useless-call)

      The function invocation can be written by Function.prototype.call() and Function.prototype.apply(). But Function.prototype.call() and Function.prototype.apply() are slower than the normal function invocation.

      Rule Details

      This rule is aimed to flag usage of Function.prototype.call() and Function.prototype.apply() that can be replaced with the normal function invocation.

      Examples of incorrect code for this rule:

      /*eslint no-useless-call: "error"*/

// These are same as `foo(1, 2, 3);`
foo.call(undefined, 1, 2, 3);
foo.apply(undefined, [1, 2, 3]);
foo.call(null, 1, 2, 3);
foo.apply(null, [1, 2, 3]);

// These are same as `obj.foo(1, 2, 3);`
obj.foo.call(obj, 1, 2, 3);
obj.foo.apply(obj, [1, 2, 3]);

      Examples of correct code for this rule:

      /*eslint no-useless-call: "error"*/

// The `this` binding is different.
foo.call(obj, 1, 2, 3);
foo.apply(obj, [1, 2, 3]);
obj.foo.call(null, 1, 2, 3);
obj.foo.apply(null, [1, 2, 3]);
obj.foo.call(otherObj, 1, 2, 3);
obj.foo.apply(otherObj, [1, 2, 3]);

// The argument list is variadic.
foo.apply(undefined, args);
foo.apply(null, args);
obj.foo.apply(obj, args);

      Known Limitations

      This rule compares code statically to check whether or not thisArg is changed. So if the code about thisArg is a dynamic expression, this rule cannot judge correctly.

      Examples of incorrect code for this rule:

      /*eslint no-useless-call: "error"*/

a[i++].foo.call(a[i++], 1, 2, 3);

      Examples of correct code for this rule:

      /*eslint no-useless-call: "error"*/

a[++i].foo.call(a[i], 1, 2, 3);

      When Not To Use It

      If you don't want to be notified about unnecessary .call() and .apply(), you can safely disable this rule. Source: http://eslint.org/docs/rules/

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          this.$el.html(KB.Templates.render(KB.Config.getFieldJsUrl() + 'templates/plupload/' + this.template, data));
      Severity: Minor
      Found in js/src/fields/controls/KB.Plupload.js and 1 other location - About 50 mins to fix
      js/src/fields/controls/KB.Plupload.js on lines 143..143

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          this.$el.append(KB.Templates.render(KB.Config.getFieldJsUrl() + 'templates/plupload/' + this.initTemplate, data));
      Severity: Minor
      Found in js/src/fields/controls/KB.Plupload.js and 1 other location - About 50 mins to fix
      js/src/fields/controls/KB.Plupload.js on lines 158..158

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status