kai-jacobsen/kontentblocks

View on GitHub
js/src/fields/controls/flexfields/FlexFieldsFactory.js

Summary

Maintainability
A
1 hr
Test Coverage

Method 'factorNewItem' has a complexity of 11.
Open

  factorNewItem: function (data, obj) {

Limit Cyclomatic Complexity (complexity)

Cyclomatic complexity measures the number of linearly independent paths through a program's source code. This rule allows setting a cyclomatic complexity threshold.

function a(x) {
    if (true) {
        return x; // 1st path
    } else if (false) {
        return x+1; // 2nd path
    } else {
        return 4; // 3rd path
    }
}

Rule Details

This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is 20).

Examples of incorrect code for a maximum of 2:

/*eslint complexity: ["error", 2]*/

function a(x) {
    if (true) {
        return x;
    } else if (false) {
        return x+1;
    } else {
        return 4; // 3rd path
    }
}

Examples of correct code for a maximum of 2:

/*eslint complexity: ["error", 2]*/

function a(x) {
    if (true) {
        return x;
    } else {
        return 4;
    }
}

Options

Optionally, you may specify a max object property:

"complexity": ["error", 2]

is equivalent to

"complexity": ["error", { "max": 2 }]

Deprecated: the object property maximum is deprecated. Please use the property max instead.

When Not To Use It

If you can't determine an appropriate complexity limit for your code, then it's best to disable this rule.

Further Reading

Related Rules

  • [max-depth](max-depth.md)
  • [max-len](max-len.md)
  • [max-nested-callbacks](max-nested-callbacks.md)
  • [max-params](max-params.md)
  • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

Function factorNewItem has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  factorNewItem: function (data, obj) {
    var uid = obj['_meta'].uid || null;
    var title = obj['_meta'].title || null;
    var type = obj['_meta'].type;
    var status = obj['_meta'].status || 'visible';
Severity: Minor
Found in js/src/fields/controls/flexfields/FlexFieldsFactory.js - About 1 hr to fix

    Unexpected prompt.
    Open

          title = title || prompt(text, '');

    Disallow Use of Alert (no-alert)

    JavaScript's alert, confirm, and prompt functions are widely considered to be obtrusive as UI elements and should be replaced by a more appropriate custom UI implementation. Furthermore, alert is often used while debugging code, which should be removed before deployment to production.

    alert("here!");

    Rule Details

    This rule is aimed at catching debugging code that should be removed and popup UI elements that should be replaced with less obtrusive, custom UIs. As such, it will warn when it encounters alert, prompt, and confirm function calls which are not shadowed.

    Examples of incorrect code for this rule:

    /*eslint no-alert: "error"*/
    
    alert("here!");
    
    confirm("Are you sure?");
    
    prompt("What's your name?", "John Doe");

    Examples of correct code for this rule:

    /*eslint no-alert: "error"*/
    
    customAlert("Something happened!");
    
    customConfirm("Are you sure?");
    
    customPrompt("Who are you?");
    
    function foo() {
        var alert = myCustomLib.customAlert;
        alert();
    }

    Related Rules

    There are no issues that match your filters.

    Category
    Status