File EditModalModules.js
has 395 lines of code (exceeds 250 allowed). Consider refactoring. Open
var Logger = require('common/Logger');
var ModalFieldCollection = require('frontend/Collections/ModalFieldCollection');
var LoadingAnimation = require('frontend/Views/LoadingAnimation');
var Config = require('common/Config');
var Ui = require('common/UI');
Function render
has 80 lines of code (exceeds 25 allowed). Consider refactoring. Open
render: function (reload) {
var that = this,
json;
Logger.User.info('Frontend modal retrieves data from the server');
json = this.model.toJSON();
exports
has 26 functions (exceeds 20 allowed). Consider refactoring. Open
module.exports = Backbone.View.extend({
tagName: 'div',
id: 'onsite-modal',
timerId: null,
viewStack: {},
Function success
has 56 lines of code (exceeds 25 allowed). Consider refactoring. Open
success: function (res) {
// clear form content
that.$inner.empty();
// clear fields on ModuleView
that.ModuleView.clearFields();
Method 'moduleUpdated' has a complexity of 7. Open
moduleUpdated: function (res, b, c, save, notice) {
- Read upRead up
- Exclude checks
Limit Cyclomatic Complexity (complexity)
Cyclomatic complexity measures the number of linearly independent paths through a program's source code. This rule allows setting a cyclomatic complexity threshold.
function a(x) {
if (true) {
return x; // 1st path
} else if (false) {
return x+1; // 2nd path
} else {
return 4; // 3rd path
}
}
Rule Details
This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is 20
).
Examples of incorrect code for a maximum of 2:
/*eslint complexity: ["error", 2]*/
function a(x) {
if (true) {
return x;
} else if (false) {
return x+1;
} else {
return 4; // 3rd path
}
}
Examples of correct code for a maximum of 2:
/*eslint complexity: ["error", 2]*/
function a(x) {
if (true) {
return x;
} else {
return 4;
}
}
Options
Optionally, you may specify a max
object property:
"complexity": ["error", 2]
is equivalent to
"complexity": ["error", { "max": 2 }]
Deprecated: the object property maximum
is deprecated. Please use the property max
instead.
When Not To Use It
If you can't determine an appropriate complexity limit for your code, then it's best to disable this rule.
Further Reading
Related Rules
- [max-depth](max-depth.md)
- [max-len](max-len.md)
- [max-nested-callbacks](max-nested-callbacks.md)
- [max-params](max-params.md)
- [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/
Function moduleUpdated
has 38 lines of code (exceeds 25 allowed). Consider refactoring. Open
moduleUpdated: function (res, b, c, save, notice) {
var that = this;
that.model.trigger('modal.serialize.before');
Function render
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
render: function (reload) {
var that = this,
json;
Logger.User.info('Frontend modal retrieves data from the server');
json = this.model.toJSON();
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function moduleUpdated
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
moduleUpdated: function (res, b, c, save, notice) {
var that = this;
that.model.trigger('modal.serialize.before');
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function recalibrate
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
recalibrate: function () {
var winH,
conH,
position,
winDiff;
Function moduleUpdated
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
moduleUpdated: function (res, b, c, save, notice) {
Function recalibrate
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
recalibrate: function () {
var winH,
conH,
position,
winDiff;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
TODO found Open
// TODO maybe check if admin bar is around
- Exclude checks
Identical blocks of code found in 2 locations. Consider refactoring. Open
templateResult: function (state) {
if (!state.id) {
return state.text;
}
var desc = state.element.dataset.tpldesc;
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 77.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76