Sign upLogin

kai-jacobsen/kontentblocks

View on GitHub
Star
js/src/frontend/Views/LayoutAreaView.js

Summary

Maintainability
A
1 hr
Test Coverage

Function initDraggable has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  initDraggable: function () {
    var $source, $target, $sourcecontainer, $targetcontainer;
    var that = this;
    this.$('.kbml-slot-ref').draggable({
      revert: 'invalid',
Severity: Minor
Found in js/src/frontend/Views/LayoutAreaView.js - About 1 hr to fix

    Unexpected alert.
    Open

            alert(JSON.stringify(slots));
    Severity: Minor
    Found in js/src/frontend/Views/LayoutAreaView.js by eslint

    Disallow Use of Alert (no-alert)

    JavaScript's alert, confirm, and prompt functions are widely considered to be obtrusive as UI elements and should be replaced by a more appropriate custom UI implementation. Furthermore, alert is often used while debugging code, which should be removed before deployment to production.

    alert("here!");

    Rule Details

    This rule is aimed at catching debugging code that should be removed and popup UI elements that should be replaced with less obtrusive, custom UIs. As such, it will warn when it encounters alert, prompt, and confirm function calls which are not shadowed.

    Examples of incorrect code for this rule:

    /*eslint no-alert: "error"*/

alert("here!");

confirm("Are you sure?");

prompt("What's your name?", "John Doe");

    Examples of correct code for this rule:

    /*eslint no-alert: "error"*/

customAlert("Something happened!");

customConfirm("Are you sure?");

customPrompt("Who are you?");

function foo() {
    var alert = myCustomLib.customAlert;
    alert();
}

    Related Rules

    There are no issues that match your filters.

    Category
    Status