kai-jacobsen/kontentblocks

View on GitHub
js/src/frontend/Views/Sidebar/AreaDetails/ModuleDragItem.js

Summary

Maintainability
A
2 hrs
Test Coverage

Function initialize has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  initialize: function (options) {
    var that = this;
    // CategoryView
    this.controller = options.controller;
    // ModuleListController
Severity: Minor
Found in js/src/frontend/Views/Sidebar/AreaDetails/ModuleDragItem.js - About 1 hr to fix

    Function create has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      create: function (ui) {
        var Area, data, module;
        // check if capability is right for this action
        if (Checks.userCan('create_kontentblocks')) {
        } else {
    Severity: Minor
    Found in js/src/frontend/Views/Sidebar/AreaDetails/ModuleDragItem.js - About 1 hr to fix

      Empty block statement.
      Open

          if (Checks.userCan('create_kontentblocks')) {

      disallow empty block statements (no-empty)

      Empty block statements, while not technically errors, usually occur due to refactoring that wasn't completed. They can cause confusion when reading code.

      Rule Details

      This rule disallows empty block statements. This rule ignores block statements which contain a comment (for example, in an empty catch or finally block of a try statement to indicate that execution should continue regardless of errors).

      Examples of incorrect code for this rule:

      /*eslint no-empty: "error"*/
      
      if (foo) {
      }
      
      while (foo) {
      }
      
      switch(foo) {
      }
      
      try {
          doSomething();
      } catch(ex) {
      
      } finally {
      
      }

      Examples of correct code for this rule:

      /*eslint no-empty: "error"*/
      
      if (foo) {
          // empty
      }
      
      while (foo) {
          /* empty */
      }
      
      try {
          doSomething();
      } catch (ex) {
          // continue regardless of error
      }
      
      try {
          doSomething();
      } finally {
          /* continue regardless of error */
      }

      Options

      This rule has an object option for exceptions:

      • "allowEmptyCatch": true allows empty catch clauses (that is, which do not contain a comment)

      allowEmptyCatch

      Examples of additional correct code for this rule with the { "allowEmptyCatch": true } option:

      /* eslint no-empty: ["error", { "allowEmptyCatch": true }] */
      try {
          doSomething();
      } catch (ex) {}
      
      try {
          doSomething();
      }
      catch (ex) {}
      finally {
          /* continue regardless of error */
      }

      When Not To Use It

      If you intentionally use empty block statements then you can disable this rule.

      Related Rules

      There are no issues that match your filters.

      Category
      Status