Sign upLogin

karlentwistle/ruby_home

View on GitHub
Star

Showing 3 of 19 total issues

Method run has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

      def run(sock)
        session = Session.new(sock)

        loop do
          req = HAPRequest.new(@config, session: session)
Severity: Minor
Found in lib/ruby_home/hap/server.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def run(sock)
        session = Session.new(sock)

        loop do
          req = HAPRequest.new(@config, session: session)
Severity: Minor
Found in lib/ruby_home/hap/server.rb - About 1 hr to fix

    Method exchange has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def exchange
        encrypted_data = unpack_request[:encrypted_data]

        hkdf = HAP::Crypto::HKDF.new(info: "Pair-Setup-Encrypt-Info", salt: "Pair-Setup-Encrypt-Salt")
        key = hkdf.encrypt(session.session_key)
    Severity: Minor
    Found in lib/ruby_home/http/controllers/pair_setups_controller.rb - About 1 hr to fix
      Severity
      Category
      Status
      Source
      Language