Sign upLogin

kaspernj/translatable_menus

View on GitHub
Star

Showing 4 of 4 total issues

Method integrate! has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.integrate!
    ActiveAdmin.register TranslatableMenus::TranslatableMenu do
      permit_params :identifier, :sort_number, :menu_id, :http_method, :require_not_signed_in, :require_signed_in, :require_callbacks,
        :default_url, :default_active, :default_title, :translations_attributes => [:id, :locale, :title, :url, :active]
Severity: Major
Found in lib/translatable_menus/active_admin_integrator.rb - About 2 hrs to fix

    Method should_show_menu? has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

      def should_show_menu?(menu)
    if !menu.url && !menu.default_url
      return false
    elsif !menu.active_to_use?
      return false
    Severity: Minor
    Found in app/helpers/translatable_menus/translatable_menu_helper.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

          return false if result != true
    Severity: Major
    Found in app/helpers/translatable_menus/translatable_menu_helper.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

          return true
      Severity: Major
      Found in app/helpers/translatable_menus/translatable_menu_helper.rb - About 30 mins to fix
        Severity
        Category
        Status
        Source
        Language