keboola/syrup-component-bundle

View on GitHub
Command/JobCommand.php

Summary

Maintainability
B
6 hrs
Test Coverage

Method execute has 94 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $jobId = $input->getArgument('jobId');

        $this->logger = $this->getContainer()->get('logger');
Severity: Major
Found in Command/JobCommand.php - About 3 hrs to fix

    Function execute has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function execute(InputInterface $input, OutputInterface $output)
        {
            $jobId = $input->getArgument('jobId');
    
            $this->logger = $this->getContainer()->get('logger');
    Severity: Minor
    Found in Command/JobCommand.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method init has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function init($jobId)
        {
            // Get job from ES
            $this->job = $this->getJobManager()->getJob($jobId);
    
    
    Severity: Minor
    Found in Command/JobCommand.php - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status