kengz/SLM-Lab

View on GitHub
slm_lab/agent/algorithm/hydra_dqn.py

Summary

Maintainability
A
25 mins
Test Coverage
A
93%

Function space_train has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
Open

    def space_train(self):
        '''
        Completes one training step for the agent if it is time to train.
        i.e. the environment timestep is greater than the minimum training timestep and a multiple of the training_frequency.
        Each training step consists of sampling n batches from the agent's memory.
Severity: Minor
Found in slm_lab/agent/algorithm/hydra_dqn.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

TODO found
Open

        # TODO use the same loss_fn but do not reduce yet
Severity: Minor
Found in slm_lab/agent/algorithm/hydra_dqn.py by fixme

There are no issues that match your filters.

Category
Status