Sign upLogin

kengz/SLM-Lab

View on GitHub
Star
slm_lab/agent/algorithm/sac.py

Summary

Maintainability
A
2 hrs
Test Coverage
A
94%

Function init_nets has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def init_nets(self, global_nets=None):
        '''
        Networks: net(actor/policy), q1_net, target_q1_net, q2_net, target_q2_net
        All networks are separate, and have the same hidden layer architectures and optim specs, so tuning is minimal
        '''
Severity: Minor
Found in slm_lab/agent/algorithm/sac.py - About 1 hr to fix

    TODO found
    Open

                # TODO support multi-discrete actions
    Severity: Minor
    Found in slm_lab/agent/algorithm/sac.py by fixme

    Identical blocks of code found in 7 locations. Consider refactoring.
    Open

                logger.debug(f'Trained {self.name} at epi: {clock.epi}, frame: {clock.frame}, t: {clock.t}, total_reward so far: {self.body.env.total_reward}, loss: {loss:g}')
    Severity: Major
    Found in slm_lab/agent/algorithm/sac.py and 6 other locations - About 1 hr to fix
    slm_lab/agent/algorithm/actor_critic.py on lines 298..298
    slm_lab/agent/algorithm/dqn.py on lines 144..144
    slm_lab/agent/algorithm/ppo.py on lines 212..212
    slm_lab/agent/algorithm/reinforce.py on lines 158..158
    slm_lab/agent/algorithm/sarsa.py on lines 144..144
    slm_lab/agent/algorithm/sil.py on lines 148..148

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status