kengz/SLM-Lab

View on GitHub
slm_lab/agent/net/net_util.py

Summary

Maintainability
A
1 hr
Test Coverage
B
86%

Function gen_assert_trained has a Cognitive Complexity of 13 (exceeds 10 allowed). Consider refactoring.
Open

def gen_assert_trained(pre_model):
    '''
    Generate assert_trained function used to check weight updates
    @example

Severity: Minor
Found in slm_lab/agent/net/net_util.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function get_policy_out_dim has a Cognitive Complexity of 12 (exceeds 10 allowed). Consider refactoring.
Open

def get_policy_out_dim(body):
    '''Helper method to construct the policy network out_dim for a body according to is_discrete, action_type'''
    action_dim = body.action_dim
    if body.is_discrete:
        if body.action_type == 'multi_discrete':
Severity: Minor
Found in slm_lab/agent/net/net_util.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

TODO found
Open

            # TODO if without momentum, weights should not change too
Severity: Minor
Found in slm_lab/agent/net/net_util.py by fixme

There are no issues that match your filters.

Category
Status