kengz/SLM-Lab

View on GitHub
slm_lab/agent/net/net_util.py

Summary

Maintainability
A
2 hrs
Test Coverage
B
82%

Function dev_check_training_step has a Cognitive Complexity of 22 (exceeds 10 allowed). Consider refactoring.
Open

def dev_check_training_step(fn):
    '''
    Decorator to check if net.training_step actually updates the network weights properly
    Triggers only if to_check_training_step is True (dev/test mode)
    @example
Severity: Minor
Found in slm_lab/agent/net/net_util.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function get_policy_out_dim has a Cognitive Complexity of 12 (exceeds 10 allowed). Consider refactoring.
Open

def get_policy_out_dim(body):
    '''Helper method to construct the policy network out_dim for a body according to is_discrete, action_type'''
    action_dim = body.action_dim
    if body.is_discrete:
        if body.action_type == 'multi_discrete':
Severity: Minor
Found in slm_lab/agent/net/net_util.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

TODO found
Open

                # TODO change this to one slicable layer for efficiency
Severity: Minor
Found in slm_lab/agent/net/net_util.py by fixme

TODO found
Open

            # TODO if without momentum, parameters should not change too
Severity: Minor
Found in slm_lab/agent/net/net_util.py by fixme

There are no issues that match your filters.

Category
Status