kengz/SLM-Lab

View on GitHub
slm_lab/experiment/control.py

Summary

Maintainability
A
45 mins
Test Coverage
B
83%

Function try_ckpt has a Cognitive Complexity of 13 (exceeds 10 allowed). Consider refactoring.
Open

    def try_ckpt(self, agent, env):
        '''Try to checkpoint agent at the start, save_freq, and the end'''
        tick = env.clock.get(env.max_tick_unit)
        to_ckpt = False
        if not util.in_eval_lab_modes() and tick <= env.max_tick:
Severity: Minor
Found in slm_lab/experiment/control.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

TODO found
Open

        # TODO ckpt and eval not implemented for SpaceSession
Severity: Minor
Found in slm_lab/experiment/control.py by fixme

TODO found
Open

            # TODO also create shared optimizer here
Severity: Minor
Found in slm_lab/experiment/control.py by fixme

There are no issues that match your filters.

Category
Status