khiav223577/atomically

View on GitHub
lib/atomically/query_service.rb

Summary

Maintainability
A
1 hr
Test Coverage
A
95%

Method pay_all has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

  def pay_all(hash, update_columns, primary_key: :id) # { id => pay_count }
    return 0 if hash.blank?

    update_columns = update_columns.map(&method(:quote_column))

Severity: Minor
Found in lib/atomically/query_service.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update_and_return_number_of_updated_rows has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Wontfix

  def update_and_return_number_of_updated_rows(attrs, from_value)
    model = @model
    return open_update_all_scope do
      update(updated_at: Time.now)

Severity: Minor
Found in lib/atomically/query_service.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status