Showing 156 of 405 total issues
Cyclomatic complexity is too high in class FormFieldChecker. (6) Open
class FormFieldChecker(checkers.BaseChecker):
name = "form-field-label-checker"
msgs = {
"R4811": (
- Read upRead up
- Exclude checks
Cyclomatic Complexity
Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.
Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:
Construct | Effect on CC | Reasoning |
---|---|---|
if | +1 | An if statement is a single decision. |
elif | +1 | The elif statement adds another decision. |
else | +0 | The else statement does not cause a new decision. The decision is at the if. |
for | +1 | There is a decision at the start of the loop. |
while | +1 | There is a decision at the while statement. |
except | +1 | Each except branch adds a new conditional path of execution. |
finally | +0 | The finally block is unconditionally executed. |
with | +1 | The with statement roughly corresponds to a try/except block (see PEP 343 for details). |
assert | +1 | The assert statement internally roughly equals a conditional statement. |
Comprehension | +1 | A list/set/dict comprehension of generator expression is equivalent to a for loop. |
Boolean Operator | +1 | Every boolean operator (and, or) adds a decision point. |
Cyclomatic complexity is too high in function mailto. (6) Open
@override(settings.LANGUAGE_CODE)
def mailto( # pylint: disable=invalid-name
template_name,
subject,
recipients=None,
- Read upRead up
- Exclude checks
Cyclomatic Complexity
Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.
Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:
Construct | Effect on CC | Reasoning |
---|---|---|
if | +1 | An if statement is a single decision. |
elif | +1 | The elif statement adds another decision. |
else | +0 | The else statement does not cause a new decision. The decision is at the if. |
for | +1 | There is a decision at the start of the loop. |
while | +1 | There is a decision at the while statement. |
except | +1 | Each except branch adds a new conditional path of execution. |
finally | +0 | The finally block is unconditionally executed. |
with | +1 | The with statement roughly corresponds to a try/except block (see PEP 343 for details). |
assert | +1 | The assert statement internally roughly equals a conditional statement. |
Comprehension | +1 | A list/set/dict comprehension of generator expression is equivalent to a for loop. |
Boolean Operator | +1 | Every boolean operator (and, or) adds a decision point. |
Cyclomatic complexity is too high in method post. (6) Open
def post(self, request):
if not self._is_request_data_valid(request):
return HttpResponseRedirect(request.META.get("HTTP_REFERER", "/"))
# Do the clone action
- Read upRead up
- Exclude checks
Cyclomatic Complexity
Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.
Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:
Construct | Effect on CC | Reasoning |
---|---|---|
if | +1 | An if statement is a single decision. |
elif | +1 | The elif statement adds another decision. |
else | +0 | The else statement does not cause a new decision. The decision is at the if. |
for | +1 | There is a decision at the start of the loop. |
while | +1 | There is a decision at the while statement. |
except | +1 | Each except branch adds a new conditional path of execution. |
finally | +0 | The finally block is unconditionally executed. |
with | +1 | The with statement roughly corresponds to a try/except block (see PEP 343 for details). |
assert | +1 | The assert statement internally roughly equals a conditional statement. |
Comprehension | +1 | A list/set/dict comprehension of generator expression is equivalent to a for loop. |
Boolean Operator | +1 | Every boolean operator (and, or) adds a decision point. |
Cyclomatic complexity is too high in function deny_uploads_containing_script_tag. (6) Open
def deny_uploads_containing_script_tag(uploaded_file):
for chunk in uploaded_file.chunks(2048):
for tag_name in generally_xss_unsafe:
if chunk.lower().find(b"<" + tag_name.encode()) > -1:
raise ValidationError(_(f"File contains forbidden tag: <{tag_name}>"))
- Read upRead up
- Exclude checks
Cyclomatic Complexity
Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.
Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:
Construct | Effect on CC | Reasoning |
---|---|---|
if | +1 | An if statement is a single decision. |
elif | +1 | The elif statement adds another decision. |
else | +0 | The else statement does not cause a new decision. The decision is at the if. |
for | +1 | There is a decision at the start of the loop. |
while | +1 | There is a decision at the while statement. |
except | +1 | Each except branch adds a new conditional path of execution. |
finally | +0 | The finally block is unconditionally executed. |
with | +1 | The with statement roughly corresponds to a try/except block (see PEP 343 for details). |
assert | +1 | The assert statement internally roughly equals a conditional statement. |
Comprehension | +1 | A list/set/dict comprehension of generator expression is equivalent to a for loop. |
Boolean Operator | +1 | Every boolean operator (and, or) adds a decision point. |
Cyclomatic complexity is too high in method dumps_result. (6) Open
def dumps_result(self, result: JsonResult) -> str:
if isinstance(result, JsonSuccessResult):
if isinstance(result.data, str):
result.data = html.escape(result.data)
elif isinstance(result.data, timedelta):
- Read upRead up
- Exclude checks
Cyclomatic Complexity
Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.
Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:
Construct | Effect on CC | Reasoning |
---|---|---|
if | +1 | An if statement is a single decision. |
elif | +1 | The elif statement adds another decision. |
else | +0 | The else statement does not cause a new decision. The decision is at the if. |
for | +1 | There is a decision at the start of the loop. |
while | +1 | There is a decision at the while statement. |
except | +1 | Each except branch adds a new conditional path of execution. |
finally | +0 | The finally block is unconditionally executed. |
with | +1 | The with statement roughly corresponds to a try/except block (see PEP 343 for details). |
assert | +1 | The assert statement internally roughly equals a conditional statement. |
Comprehension | +1 | A list/set/dict comprehension of generator expression is equivalent to a for loop. |
Boolean Operator | +1 | Every boolean operator (and, or) adds a decision point. |
Cyclomatic complexity is too high in function is_api_function. (6) Open
def is_api_function(node):
# API functions always have @rpc_method decorator
if not node.decorators:
return False
- Read upRead up
- Exclude checks
Cyclomatic Complexity
Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.
Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:
Construct | Effect on CC | Reasoning |
---|---|---|
if | +1 | An if statement is a single decision. |
elif | +1 | The elif statement adds another decision. |
else | +0 | The else statement does not cause a new decision. The decision is at the if. |
for | +1 | There is a decision at the start of the loop. |
while | +1 | There is a decision at the while statement. |
except | +1 | Each except branch adds a new conditional path of execution. |
finally | +0 | The finally block is unconditionally executed. |
with | +1 | The with statement roughly corresponds to a try/except block (see PEP 343 for details). |
assert | +1 | The assert statement internally roughly equals a conditional statement. |
Comprehension | +1 | A list/set/dict comprehension of generator expression is equivalent to a for loop. |
Boolean Operator | +1 | Every boolean operator (and, or) adds a decision point. |
Cyclomatic complexity is too high in method visit_call. (6) Open
def visit_call(self, node):
if node.func.as_string().endswith("Field") and node.keywords:
for keyword in node.keywords:
if keyword.arg == "label":
self.add_message("form-field-label-used", node=node)
- Read upRead up
- Exclude checks
Cyclomatic Complexity
Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.
Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:
Construct | Effect on CC | Reasoning |
---|---|---|
if | +1 | An if statement is a single decision. |
elif | +1 | The elif statement adds another decision. |
else | +0 | The else statement does not cause a new decision. The decision is at the if. |
for | +1 | There is a decision at the start of the loop. |
while | +1 | There is a decision at the while statement. |
except | +1 | Each except branch adds a new conditional path of execution. |
finally | +0 | The finally block is unconditionally executed. |
with | +1 | The with statement roughly corresponds to a try/except block (see PEP 343 for details). |
assert | +1 | The assert statement internally roughly equals a conditional statement. |
Comprehension | +1 | A list/set/dict comprehension of generator expression is equivalent to a for loop. |
Boolean Operator | +1 | Every boolean operator (and, or) adds a decision point. |
Function displayProperties
has 44 lines of code (exceeds 25 allowed). Consider refactoring. Open
export function displayProperties (objectId, objectAttrName, viewMethod, removeMethod) {
const container = $('#properties-accordion')
const propertyTemplate = $('#property-fragment')[0].content
const valueTemplate = $(propertyTemplate).find('template')[0].content
const shownProperties = []
Function initializePage
has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
export function initializePage () {
table = $('#test-case-health-table').DataTable({
ajax: function (data, callback, settings) {
const query = {}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function loadBugs
has 43 lines of code (exceeds 25 allowed). Consider refactoring. Open
export function loadBugs (selector, filter) {
const noRecordsFoundText = $('.bugs-table').data('no-records-found-text')
$(selector).DataTable({
ajax: (data, callback, settings) => {
Function quickSearchAndAddTestCase
has 41 lines of code (exceeds 25 allowed). Consider refactoring. Open
export function quickSearchAndAddTestCase (objId, pageCallback, cache, initialQuery = {}) {
// + button
$('#btn-add-case').click(function () {
pageCallback(objId)
Function tree_view_html
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
def tree_view_html(self):
"""
Returns nested tree structure represented as Patterfly TreeView!
Relies on the fact that tree nodes are returned in DFS
order!
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function preProcessData
has 39 lines of code (exceeds 25 allowed). Consider refactoring. Open
function preProcessData (data, callbackF) {
const caseIds = []
data.forEach(function (element) {
caseIds.push(element.id)
})
Function ajax
has 38 lines of code (exceeds 25 allowed). Consider refactoring. Open
ajax: function (data, callbackF, settings) {
const query = {}
const productIds = $('#id_product').val()
if (productIds.length) {
Function pageTestcasesMutableReadyHandler
has 38 lines of code (exceeds 25 allowed). Consider refactoring. Open
export function pageTestcasesMutableReadyHandler () {
$('#id_template').change(function () {
window.markdownEditor.codemirror.setValue($(this).val())
})
Function pageTelemetryReadyHandler
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
export function pageTelemetryReadyHandler (pageId) {
initializeDateTimePicker('#id_before')
initializeDateTimePicker('#id_after')
const drawChart = {
Function getTestCaseRowContent
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
function getTestCaseRowContent (rowContent, testCase, permissions) {
const row = $(rowContent)
row[0].firstElementChild.dataset.testcasePk = testCase.id
row.find('.js-test-case-link').html(`TC-${testCase.id}: ${testCase.summary}`).attr('href', `/case/${testCase.id}/`)
Function pageTestplansGetReadyHandler
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
export function pageTestplansGetReadyHandler () {
const testPlanDataElement = $('#test_plan_pk')
const testPlanId = testPlanDataElement.data('testplan-pk')
const permissions = {
Function addLinkToExecutions
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
function addLinkToExecutions (testExecutionIDs) {
// remove all previous event handlers
$('.add-hyperlink-form').off('submit')
// this handler must be here, because if we bind it when the page is loaded.
Function deny_uploads_containing_script_tag
has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
def deny_uploads_containing_script_tag(uploaded_file):
for chunk in uploaded_file.chunks(2048):
for tag_name in generally_xss_unsafe:
if chunk.lower().find(b"<" + tag_name.encode()) > -1:
raise ValidationError(_(f"File contains forbidden tag: <{tag_name}>"))
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"