Sign upLogin

kiwitcms/Kiwi

View on GitHub
Star

Showing 104 of 405 total issues

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    document.getElementById('id_version').onchange = function () {
        $('#id_version').selectpicker('refresh')
        populateBuild()
    }
Severity: Major
Found in tcms/bugs/static/bugs/js/mutable.js and 3 other locations - About 30 mins to fix
tcms/bugs/static/bugs/js/mutable.js on lines 20..23
tcms/testcases/static/testcases/js/mutable.js on lines 25..28
tcms/testplans/static/testplans/js/mutable.js on lines 19..22

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    document.getElementById('id_product').onchange = function () {
        $('#id_product').selectpicker('refresh')
        populateVersion()
    }
Severity: Major
Found in tcms/bugs/static/bugs/js/mutable.js and 3 other locations - About 30 mins to fix
tcms/bugs/static/bugs/js/mutable.js on lines 25..28
tcms/testcases/static/testcases/js/mutable.js on lines 25..28
tcms/testplans/static/testplans/js/mutable.js on lines 19..22

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Merge this if statement with the enclosing one.
Open

        if (not os.path.exists(filename)) or (not read_installation_id(filename)):
Severity: Major
Found in tcms/core/checks.py by sonar-python

Merging collapsible if statements increases the code's readability.

Noncompliant Code Example

if condition1:
    if condition2:
        # ...

Compliant Solution

if condition1 and condition2:
    # ...

Rename function "makeExtension" to match the regular expression ^[a-z_][a-z0-9_]{2,}$.
Open

def makeExtension(**kwargs):  # pylint: disable=invalid-name
Severity: Major
Found in tcms/utils/markdown.py by sonar-python

Shared coding conventions allow teams to collaborate efficiently. This rule checks that all function names match a provided regular expression.

Noncompliant Code Example

With the default provided regular expression: ^[a-z_][a-z0-9_]{2,30}$

def MyFunction(a,b):
    ...

Compliant Solution

def my_function(a,b):
    ...
Severity
Category
Status
Source
Language