Sign upLogin

kiwitcms/Kiwi

View on GitHub
Star
kiwi_lint/dunder_attributes.py

Summary

Maintainability
A
0 mins
Test Coverage

Cyclomatic complexity is too high in class DunderClassAttributeChecker. (8)
Open

class DunderClassAttributeChecker(checkers.BaseChecker):
    name = "dunder-class-attribute-checker"

    msgs = {
        "C4401": (
Severity: Minor
Found in kiwi_lint/dunder_attributes.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Cyclomatic complexity is too high in method visit_classdef. (8)
Open

    @utils.only_required_for_messages("dunder-class-attribute")
    def visit_classdef(self, node):
        """Detect when class attributes use double underscores."""
        # we can redefine special methods (e.g. __iter__) and some attributes,
        # e.g. __doc__, by declaring them as class attributes. Exclude them from the
Severity: Minor
Found in kiwi_lint/dunder_attributes.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Function visit_classdef has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Wontfix

    def visit_classdef(self, node):
        """Detect when class attributes use double underscores."""
        # we can redefine special methods (e.g. __iter__) and some attributes,
        # e.g. __doc__, by declaring them as class attributes. Exclude them from the
        # test below.
Severity: Minor
Found in kiwi_lint/dunder_attributes.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status