src/Command/Elasticsearch/Agg/Metrics.php

Summary

Maintainability
A
0 mins
Test Coverage

The variable $query_key is not named in camelCase.
Open

    public function processResults(\ECL\SymbolTable $table, array $results) {
        $key = $table->resolve($this->key, \ECL\Symbol::T_STR);
        $query_key = '$_' . $key;
        if(!array_key_exists($query_key, $results)) {
            return [];

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $query_key is not named in camelCase.
Open

    public function processResults(\ECL\SymbolTable $table, array $results) {
        $key = $table->resolve($this->key, \ECL\Symbol::T_STR);
        $query_key = '$_' . $key;
        if(!array_key_exists($query_key, $results)) {
            return [];

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $query_key is not named in camelCase.
Open

    public function processResults(\ECL\SymbolTable $table, array $results) {
        $key = $table->resolve($this->key, \ECL\Symbol::T_STR);
        $query_key = '$_' . $key;
        if(!array_key_exists($query_key, $results)) {
            return [];

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

There are no issues that match your filters.

Category
Status