Sign upLogin

knot-lib/cache

View on GitHub
Star

Showing 6 of 6 total issues

Function get has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    public function get($key, $default = null)
    {
        $cache_file = $this->getCacheItemFile($key);

        if (!$cache_file->exists()){
Severity: Minor
Found in src/FileCache.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method get has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function get($key, $default = null)
    {
        $cache_file = $this->getCacheItemFile($key);

        if (!$cache_file->exists()){
Severity: Minor
Found in src/FileCache.php - About 1 hr to fix

    Function get has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        public function get($key, $default = null)
    {
        $cache_info = $this->data[$key] ?? null;

        if ($cache_info === null){
    Severity: Minor
    Found in src/ArrayCache.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method get has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function get($key, $default = null)
    {
        $cache_info = $this->data[$key] ?? null;

        if ($cache_info === null){
    Severity: Minor
    Found in src/ArrayCache.php - About 1 hr to fix

      Avoid too many return statements within this method.
      Open

              return $data;
      Severity: Major
      Found in src/ArrayCache.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return $data;
        Severity: Major
        Found in src/FileCache.php - About 30 mins to fix
          Severity
          Category
          Status
          Source
          Language