konstantin1998/frontend-project-lvl2

View on GitHub

Showing 5 of 7 total issues

Function differenceItem has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const differenceItem = (objBefore, objAfter, key) => {
  if (_.has(objBefore, key) && _.has(objAfter, key)) {
    if (objBefore[key] === objAfter[key]) {
      return {
        name: key,
Severity: Minor
Found in src/differenceCreator.js - About 1 hr to fix

    Function iter has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const iter = (diffTree, level = 0) => {
      const gap = '  '.repeat(2 * level + 1);
      const passThroughTree = (item) => {
        switch (item.type) {
          case 'changed': {
    Severity: Minor
    Found in src/formatters/objDiffGenerator.js - About 1 hr to fix

      Function differenceItem has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      const differenceItem = (objBefore, objAfter, key) => {
        if (_.has(objBefore, key) && _.has(objAfter, key)) {
          if (objBefore[key] === objAfter[key]) {
            return {
              name: key,
      Severity: Minor
      Found in src/differenceCreator.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

              return [startLine, iter(item.children, level + 1), finishLine].join('\n');
      Severity: Major
      Found in src/formatters/objDiffGenerator.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return iter(item.children, newPath);
        Severity: Major
        Found in src/formatters/plainDiffGenerator.js - About 30 mins to fix
          Severity
          Category
          Status
          Source
          Language