koopjs/koop-fda

View on GitHub

Showing 8 of 8 total issues

Function FDA has 216 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var FDA = function (koop) {
  var fda = koop.BaseModel(koop)
  var type = 'FDA'
  var key = 'food-recalls'

Severity: Major
Found in models/FDA.js - About 1 day to fix

    Function FDA has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
    Open

    var FDA = function (koop) {
      var fda = koop.BaseModel(koop)
      var type = 'FDA'
      var key = 'food-recalls'
    
    
    Severity: Minor
    Found in models/FDA.js - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function Controller has 102 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    var Controller = function (FDA, BaseController) {
      var controller = BaseController()
    
      // drops the cache for an item
      controller.drop = function (req, res) {
    Severity: Major
    Found in controller/index.js - About 4 hrs to fix

      Function Controller has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

      var Controller = function (FDA, BaseController) {
        var controller = BaseController()
      
        // drops the cache for an item
        controller.drop = function (req, res) {
      Severity: Minor
      Found in controller/index.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function exportFile has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        controller.exportFile = function (req, res) {
          console.log('yello')
          // change geojson to json
          var format = req.params.format.replace('geojson', 'json')
          delete req.params.format
      Severity: Minor
      Found in controller/index.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            koop.Cache.insert(type, key, geojson, 0, function (err, success) {
              if (err) {
                callback(err)
              } else {
                callback(null, success)
        Severity: Minor
        Found in models/FDA.js and 1 other location - About 50 mins to fix
        models/FDA.js on lines 65..71

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            koop.Cache.insertPartial(type, key, geojson, 0, function (err, success) {
              if (err) {
                callback(err)
              } else {
                callback(null, success)
        Severity: Minor
        Found in models/FDA.js and 1 other location - About 50 mins to fix
        models/FDA.js on lines 55..61

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function exportToFormat has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          fda.exportToFormat = function (format, dir, key, geojson, options, callback) {
        Severity: Minor
        Found in models/FDA.js - About 45 mins to fix
          Severity
          Category
          Status
          Source
          Language