Sign upLogin

koopjs/koop-fda

View on GitHub
Star

Showing 6 of 8 total issues

Function FDA has 216 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var FDA = function (koop) {
  var fda = koop.BaseModel(koop)
  var type = 'FDA'
  var key = 'food-recalls'
Severity: Major
Found in models/FDA.js - About 1 day to fix

    Function FDA has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
    Open

    var FDA = function (koop) {
  var fda = koop.BaseModel(koop)
  var type = 'FDA'
  var key = 'food-recalls'
    Severity: Minor
    Found in models/FDA.js - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function Controller has 102 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    var Controller = function (FDA, BaseController) {
  var controller = BaseController()

  // drops the cache for an item
  controller.drop = function (req, res) {
    Severity: Major
    Found in controller/index.js - About 4 hrs to fix

      Function Controller has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

      var Controller = function (FDA, BaseController) {
  var controller = BaseController()

  // drops the cache for an item
  controller.drop = function (req, res) {
      Severity: Minor
      Found in controller/index.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function exportFile has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        controller.exportFile = function (req, res) {
    console.log('yello')
    // change geojson to json
    var format = req.params.format.replace('geojson', 'json')
    delete req.params.format
      Severity: Minor
      Found in controller/index.js - About 1 hr to fix

        Function exportToFormat has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          fda.exportToFormat = function (format, dir, key, geojson, options, callback) {
        Severity: Minor
        Found in models/FDA.js - About 45 mins to fix
          Severity
          Category
          Status
          Source
          Language