kotojs/kotojs

View on GitHub

Showing 14 of 14 total issues

Function config has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
Open

  config(nameOrObject, value) {
    var key;
    var definition;
    var _Chart = this;

Severity: Minor
Found in src/chart.js - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function draw has 81 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  draw(data) {
    var bound,
      entering,
      events,
      selection,
Severity: Major
Found in src/layer.js - About 3 hrs to fix

    Function draw has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

      draw(data) {
        var bound,
          entering,
          events,
          selection,
    Severity: Minor
    Found in src/layer.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function config has 63 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      config(nameOrObject, value) {
        var key;
        var definition;
        var _Chart = this;
    
    
    Severity: Major
    Found in src/chart.js - About 2 hrs to fix

      File chart.js has 266 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      import 'babel-polyfill';
      import * as d3 from 'd3';
      import kotoAssert from './assert.js';
      import Layer from './layer.js';
      
      
      Severity: Minor
      Found in src/chart.js - About 2 hrs to fix

        Function exports has 49 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        module.exports = function (config) {
          config.set({
            basePath: './',
            frameworks: ['mocha', 'chai', 'sinon'],
            files: [
        Severity: Minor
        Found in karma.conf.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              this.merge.configs = (...args) => {
                this.configs = Object.assign({}, this.configs, ...args);
                return this.configs;
              };
          Severity: Major
          Found in src/chart.js and 1 other location - About 1 hr to fix
          src/chart.js on lines 26..29

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 57.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              this.merge.accessors = (...args) => {
                this.accessors = Object.assign({}, this.accessors, ...args);
                return this.accessors;
              };
          Severity: Major
          Found in src/chart.js and 1 other location - About 1 hr to fix
          src/chart.js on lines 22..25

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 57.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function accessor has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

            accessor (item, value) {
              var key;
              if (arguments.length === 0) {
                return this.accessors;
              }
          Severity: Minor
          Found in src/chart.js - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid deeply nested control flow statements.
          Open

                      if (definition.hasOwnProperty('constrain')) {
                        setPercentage();
                      }
          Severity: Major
          Found in src/chart.js - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                        if (definition.hasOwnProperty('setter')) {
                          definition.value = definition.setter.call(definition, nameOrObject[key]);
                        } else {
                          definition.value = nameOrObject[key];
                        }
            Severity: Major
            Found in src/chart.js - About 45 mins to fix

              Avoid too many return statements within this function.
              Open

                    return this;
              Severity: Major
              Found in src/chart.js - About 30 mins to fix

                Function constructor has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                  constructor(base, options) {
                    this._base = base;
                    this._handlers = {};
                    this._lifecycleRe = /^(enter|update|merge|exit)(:transition)?$/;
                
                
                Severity: Minor
                Found in src/layer.js - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function extend has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                  static extend(init) {
                    class chart extends this {
                      constructor(selection) {
                        var key;
                        super(selection);
                Severity: Minor
                Found in src/chart.js - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source