Sign upLogin

kputnam/stupidedi

View on GitHub
Star
lib/stupidedi/parser/builder_dsl.rb

Summary

Maintainability
D
2 days
Test Coverage

Method critique has a Cognitive Complexity of 54 (exceeds 5 allowed). Consider refactoring.
Open

      def critique(zipper, recursive = false, position = false)
        if zipper.node.simple? or zipper.node.component?
          if zipper.node.invalid?
            raise Exceptions::ParseError,
              "invalid #{zipper.node.descriptor} at #{zipper.node.position.inspect}"
Severity: Minor
Found in lib/stupidedi/parser/builder_dsl.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method critique has 88 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def critique(zipper, recursive = false, position = false)
        if zipper.node.simple? or zipper.node.component?
          if zipper.node.invalid?
            raise Exceptions::ParseError,
              "invalid #{zipper.node.descriptor} at #{zipper.node.position.inspect}"
Severity: Major
Found in lib/stupidedi/parser/builder_dsl.rb - About 3 hrs to fix

    Method segment! has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

          def segment!(name, position, *elements)
        segment_tok     = mksegment_tok(@reader.segment_dict, name, elements, position)
        machine, reader = @machine.insert(segment_tok, @strict, @reader)

        if @strict
    Severity: Minor
    Found in lib/stupidedi/parser/builder_dsl.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method segment! has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def segment!(name, position, *elements)
        segment_tok     = mksegment_tok(@reader.segment_dict, name, elements, position)
        machine, reader = @machine.insert(segment_tok, @strict, @reader)

        if @strict
    Severity: Minor
    Found in lib/stupidedi/parser/builder_dsl.rb - About 1 hr to fix

      Method critique_occurences has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

            def critique_occurences(zipper, recursive)
        occurences = Hash.new{|h,k| h[k] = 0 }

        zipper.children.each do |child|
          if child.node.respond_to?(:usage)
      Severity: Minor
      Found in lib/stupidedi/parser/builder_dsl.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid deeply nested control flow statements.
      Open

                      unless s.satisfied?(zipper)
                  raise Exceptions::ParseError,
                    "for #{zipper.node.descriptor}, #{s.reason(zipper)} at #{zipper.node.position.inspect}"
                end
      Severity: Major
      Found in lib/stupidedi/parser/builder_dsl.rb - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                  if zipper.node.invalid?
            if zipper.up.node.invalid?
              # parent is an InvalidEnvelopeVal
              raise Exceptions::ParseError,
                "#{zipper.first.node.reason} at #{zipper.first.node.position.inspect}"
        Severity: Major
        Found in lib/stupidedi/parser/builder_dsl.rb - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                  elsif zipper.node.loop?
          critique_occurences zipper, recursive

        elsif zipper.node.table?
          critique_occurences zipper, recursive
          Severity: Major
          Found in lib/stupidedi/parser/builder_dsl.rb - About 45 mins to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                          zipper.children.each_with_index do |z, i|
                critique(z)
              end

              d = zipper.node.definition
            Severity: Minor
            Found in lib/stupidedi/parser/builder_dsl.rb and 1 other location - About 45 mins to fix
            lib/stupidedi/parser/builder_dsl.rb on lines 183..191

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 40.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        zipper.children.each_with_index do |z, i|
              critique(z)
            end

            d = zipper.node.definition
            Severity: Minor
            Found in lib/stupidedi/parser/builder_dsl.rb and 1 other location - About 45 mins to fix
            lib/stupidedi/parser/builder_dsl.rb on lines 150..158

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 40.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status