Sign upLogin

kputnam/stupidedi

View on GitHub
Star
lib/stupidedi/parser/states/table_state.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method push has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def push(zipper, parent, segment_tok, segment_use, config)
        case segment_use.parent
        when Schema::TableDef
          table_def   = segment_use.parent
          table_val   = table_def.empty
Severity: Minor
Found in lib/stupidedi/parser/states/table_state.rb - About 1 hr to fix

    Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          def initialize(separators, segment_dict, instructions, zipper, children)
    Severity: Minor
    Found in lib/stupidedi/parser/states/table_state.rb - About 35 mins to fix

      Method push has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

            def push(zipper, parent, segment_tok, segment_use, config)
      Severity: Minor
      Found in lib/stupidedi/parser/states/table_state.rb - About 35 mins to fix

        Similar blocks of code found in 7 locations. Consider refactoring.
        Open

            class TableState < AbstractState
      # @return [Reader::Separators]
      attr_reader :separators

      # @return [Reader::SegmentDict]
        Severity: Major
        Found in lib/stupidedi/parser/states/table_state.rb and 6 other locations - About 1 hr to fix
        lib/stupidedi/parser/states/failure_state.rb on lines 6..33
        lib/stupidedi/parser/states/initial_state.rb on lines 6..34
        lib/stupidedi/parser/states/interchange_state.rb on lines 6..34
        lib/stupidedi/parser/states/loop_state.rb on lines 6..34
        lib/stupidedi/parser/states/transaction_set_state.rb on lines 6..34
        lib/stupidedi/parser/states/transmission_state.rb on lines 6..34

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 53.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status