Sign upLogin

kputnam/stupidedi

View on GitHub
Star
lib/stupidedi/reader/stream_reader.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method read_segment has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def read_segment
        consume_isa.flatmap do |rest|
          # The character after "ISA" is defined to be the element separator
          rest.read_character.flatmap do |char, aR|
            separators = Separators.new(nil, nil, char, nil)
Severity: Minor
Found in lib/stupidedi/reader/stream_reader.rb - About 1 hr to fix

    Method read_segment has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

          def read_segment
        consume_isa.flatmap do |rest|
          # The character after "ISA" is defined to be the element separator
          rest.read_character.flatmap do |char, aR|
            separators = Separators.new(nil, nil, char, nil)
    Severity: Minor
    Found in lib/stupidedi/reader/stream_reader.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method consume_isa has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def consume_isa
        position = 0
        buffer   = "   "

        # @todo: This would probably more optimal if it was written like
    Severity: Minor
    Found in lib/stupidedi/reader/stream_reader.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status