Sign upLogin

kputnam/stupidedi

View on GitHub
Star
lib/stupidedi/reader/token_reader.rb

Summary

Maintainability
D
2 days
Test Coverage

File token_reader.rb has 327 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module Stupidedi
  using Refinements

  module Reader
    class TokenReader
Severity: Minor
Found in lib/stupidedi/reader/token_reader.rb - About 3 hrs to fix

    Class TokenReader has 29 methods (exceeds 20 allowed). Consider refactoring.
    Open

        class TokenReader
      # @private
      SEGMENT_ID = /\A[A-Z][A-Z0-9]{1,2}\Z/

      include Inspect
    Severity: Minor
    Found in lib/stupidedi/reader/token_reader.rb - About 3 hrs to fix

      Method read_segment_id has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

            def read_segment_id
        position = 0
        buffer   = ""

        while true
      Severity: Minor
      Found in lib/stupidedi/reader/token_reader.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method read_elements has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

            def read_elements(segment_id, element_uses)
        if element_uses.empty?
          read_simple_element
        else
          element_use = element_uses.head
      Severity: Minor
      Found in lib/stupidedi/reader/token_reader.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method read_segment has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

            def read_segment
        consume_control_chars.flatmap do |start|
          # We might start reading a segment at "\nNM1...", where the "\n" is on
          # line 5, but "NM1" is on line 6. So to ensure the segment position is
          # line 6, we start with consume_control_characters.
      Severity: Minor
      Found in lib/stupidedi/reader/token_reader.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method consume_prefix has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

            def consume_prefix(s)
        return success(self) if s.empty?

        position = 0
        buffer   = ""
      Severity: Minor
      Found in lib/stupidedi/reader/token_reader.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method read_simple_element has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

            def read_simple_element(repeatable = false)
        position = 0
        buffer   = ""

        while @input.defined_at?(position)
      Severity: Minor
      Found in lib/stupidedi/reader/token_reader.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method read_segment_id has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def read_segment_id
        position = 0
        buffer   = ""

        while true
      Severity: Minor
      Found in lib/stupidedi/reader/token_reader.rb - About 1 hr to fix

        Method read_elements has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def read_elements(segment_id, element_uses)
        if element_uses.empty?
          read_simple_element
        else
          element_use = element_uses.head
        Severity: Minor
        Found in lib/stupidedi/reader/token_reader.rb - About 1 hr to fix

          Method read_component_element has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

                def read_component_element(repeatable = false)
        position = 0
        buffer   = ""

        while @input.defined_at?(position)
          Severity: Minor
          Found in lib/stupidedi/reader/token_reader.rb - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method consume has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

                def consume(s)
        return success(self) if s.empty?

        position = 0
        buffer   = " " * s.length
          Severity: Minor
          Found in lib/stupidedi/reader/token_reader.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method read_delimiter has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

                def read_delimiter
        position = 0

        while @input.defined_at?(position)
          character = @input.at(position)
          Severity: Minor
          Found in lib/stupidedi/reader/token_reader.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method read_composite_element has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

                def read_composite_element(repeatable = false)
        read_component_elements(repeatable).flatmap do |components, aR|
          token = composite(components, @input, aR.input)

          aR.read_delimiter.flatmap do |delim, bR|
          Severity: Minor
          Found in lib/stupidedi/reader/token_reader.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                def pretty_print(q)
        q.text("TokenReader")
        q.group(2, "(", ")") do
          q.breakable ""
          Severity: Minor
          Found in lib/stupidedi/reader/token_reader.rb and 2 other locations - About 15 mins to fix
          lib/stupidedi/reader/result.rb on lines 85..92
          lib/stupidedi/schema/component_element_use.rb on lines 64..71

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 26.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status