Sign upLogin

kputnam/stupidedi

View on GitHub
Star
lib/stupidedi/versions/common/element_types/r.rb

Summary

Maintainability
C
1 day
Test Coverage

Method to_x12 has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

            def to_x12(truncate = true)
              remaining =
                if @value.to_i.zero?
                  definition.max_length
                else
Severity: Minor
Found in lib/stupidedi/versions/common/element_types/r.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method to_x12 has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

            def to_x12(truncate = true)
              remaining =
                if @value.to_i.zero?
                  definition.max_length
                else
Severity: Minor
Found in lib/stupidedi/versions/common/element_types/r.rb - About 1 hr to fix

    Method initialize has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

              def initialize(id, name, min_length, max_length, max_precision = nil, description = nil, parent = nil)
    Severity: Major
    Found in lib/stupidedi/versions/common/element_types/r.rb - About 50 mins to fix

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

                class Invalid < FloatVal
            # @return [Object]
            attr_reader :value

            def initialize(value, usage, position)
      Severity: Major
      Found in lib/stupidedi/versions/common/element_types/r.rb and 3 other locations - About 2 hrs to fix
      lib/stupidedi/versions/common/element_types/an.rb on lines 146..204
      lib/stupidedi/versions/common/element_types/nn.rb on lines 56..114
      lib/stupidedi/versions/common/element_types/tm.rb on lines 44..101

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 86.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

                class Empty < Valid
            def value
              nil
            end
      Severity: Major
      Found in lib/stupidedi/versions/common/element_types/r.rb and 3 other locations - About 1 hr to fix
      lib/stupidedi/versions/common/element_types/dt.rb on lines 152..187
      lib/stupidedi/versions/common/element_types/nn.rb on lines 150..185
      lib/stupidedi/versions/common/element_types/tm.rb on lines 133..168

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 57.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

                def copy(changes = {})
            R.new \
              changes.fetch(:id, @id),
              changes.fetch(:name, @name),
              changes.fetch(:min_length, @min_length),
      Severity: Major
      Found in lib/stupidedi/versions/common/element_types/r.rb and 3 other locations - About 35 mins to fix
      lib/stupidedi/parser/states/functional_group_state.rb on lines 36..44
      lib/stupidedi/versions/common/element_types/id.rb on lines 22..30
      lib/stupidedi/versions/common/element_types/nn.rb on lines 24..32

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 34.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status