Sign upLogin

kputnam/stupidedi

View on GitHub
Star
lib/stupidedi/versions/common/element_types/tm.rb

Summary

Maintainability
D
2 days
Test Coverage

Method value has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
Open

          def value(object, usage, position)
            if object.is_a?(TimeVal)
              object#.copy(:usage => usage, :position => position)
            elsif object.blank?
              self::Empty.new(usage, position)
Severity: Minor
Found in lib/stupidedi/versions/common/element_types/tm.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File tm.rb has 252 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module Stupidedi
  using Refinements

  module Versions
    module Common
Severity: Minor
Found in lib/stupidedi/versions/common/element_types/tm.rb - About 2 hrs to fix

    Method value has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

              def value(object, usage, position)
            if object.is_a?(TimeVal)
              object#.copy(:usage => usage, :position => position)
            elsif object.blank?
              self::Empty.new(usage, position)
    Severity: Minor
    Found in lib/stupidedi/versions/common/element_types/tm.rb - About 1 hr to fix

      Method initialize has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

                def initialize(id, name, min_length, max_length, description = nil, parent = nil)
      Severity: Minor
      Found in lib/stupidedi/versions/common/element_types/tm.rb - About 45 mins to fix

        Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                    def initialize(hour, minute, second, usage, position)
        Severity: Minor
        Found in lib/stupidedi/versions/common/element_types/tm.rb - About 35 mins to fix

          Method initialize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

                      def initialize(hour, minute, second, usage, position)
              @hour, @minute, @second = hour, minute, second

              valid   = (  hour.nil? or hour.between?(0, 24))
              valid &&= (minute.nil? or not hour.nil?)
          Severity: Minor
          Found in lib/stupidedi/versions/common/element_types/tm.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method initialize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

                    def initialize(id, name, min_length, max_length, description = nil, parent = nil)
            super(id, name, min_length, max_length, description)

            unless min_length == 2 or min_length == 4 or min_length >= 6
              raise Exceptions::InvalidSchemaError,
          Severity: Minor
          Found in lib/stupidedi/versions/common/element_types/tm.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method inspect has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

                      def inspect
              id = definition.bind do |d|
                "[#{"% 5s" % d.id}: #{d.name}]".bind do |s|
                  if usage.forbidden?
                    ansi.forbidden(s)
          Severity: Minor
          Found in lib/stupidedi/versions/common/element_types/tm.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                    class Invalid < TimeVal
            # @return [Object]
            attr_reader :value

            def initialize(value, usage, position)
          Severity: Major
          Found in lib/stupidedi/versions/common/element_types/tm.rb and 3 other locations - About 2 hrs to fix
          lib/stupidedi/versions/common/element_types/an.rb on lines 146..204
          lib/stupidedi/versions/common/element_types/nn.rb on lines 56..114
          lib/stupidedi/versions/common/element_types/r.rb on lines 56..114

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 86.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                    class Empty < Valid
            def value
              nil
            end
          Severity: Major
          Found in lib/stupidedi/versions/common/element_types/tm.rb and 3 other locations - About 1 hr to fix
          lib/stupidedi/versions/common/element_types/dt.rb on lines 152..187
          lib/stupidedi/versions/common/element_types/nn.rb on lines 150..185
          lib/stupidedi/versions/common/element_types/r.rb on lines 147..182

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 57.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                    class Valid < TimeVal
            def valid?
              true
            end
          Severity: Major
          Found in lib/stupidedi/versions/common/element_types/tm.rb and 2 other locations - About 1 hr to fix
          lib/stupidedi/versions/common/element_types/dt.rb on lines 120..145
          lib/stupidedi/versions/common/element_types/nn.rb on lines 118..143

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 56.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      def copy(changes = {})
              if [:hour, :minute, :second].any?{|x| changes.include?(x) }
                changes[:value] = [changes.fetch(:hour, @hour),
                                   changes.fetch(:minute, @minute),
                                   changes.fetch(:second, @second)]
          Severity: Minor
          Found in lib/stupidedi/versions/common/element_types/tm.rb and 1 other location - About 30 mins to fix
          lib/stupidedi/versions/common/element_types/dt.rb on lines 355..362

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 33.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status