Sign upLogin

krists/refile-postgres

View on GitHub
Star

Showing 3 of 3 total issues

Method with_connection has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

      def with_connection
        if @connection_or_proc.is_a?(PG::Connection)
          yield @connection_or_proc
        else
          if @connection_or_proc.is_a?(Proc)
Severity: Minor
Found in lib/refile/postgres/smart_transaction.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method registry_table has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

      def registry_table
        unless @registry_table_validated
          with_connection do |connection|
            connection.exec_params("SELECT * FROM pg_catalog.pg_tables WHERE tablename = $1::varchar;", [@registry_table]) do |result|
              if result.count == 0
Severity: Minor
Found in lib/refile/postgres/backend.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method read has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

        def read(length = nil, buffer = nil)
          result = if length
            raise "closed" if @closed
            with_connection do |connection|
              smart_transaction(connection) do |descriptor|
Severity: Minor
Found in lib/refile/postgres/backend/reader.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language