Sign upLogin

kristuff/mishell

View on GitHub
Star

Showing 102 of 102 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

/** 
 *        _    _        _ _
 *  _ __ (_)__| |_  ___| | |
Severity: Major
Found in lib/ShellTablePrinter.php and 1 other location - About 4 days to fix
lib/TableStyle.php on lines 1..281

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 814.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

/** 
 *        _    _        _ _
 *  _ __ (_)__| |_  ___| | |
Severity: Major
Found in lib/TableStyle.php and 1 other location - About 4 days to fix
lib/ShellTablePrinter.php on lines 1..281

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 814.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function findFileWithExtension has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
Open

    private function findFileWithExtension($class, $ext)
    {
        // PSR-4 lookup
        $logicalPathPsr4 = strtr($class, '\\', DIRECTORY_SEPARATOR) . $ext;
Severity: Minor
Found in vendor/composer/ClassLoader.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

The class InstalledVersions has an overall complexity of 52 which is very high. The configured complexity threshold is 50.
Open

class InstalledVersions
{
    /**
     * @var mixed[]|null
     * @psalm-var array{root: array{name: string, version: string, reference: string, pretty_version: string, aliases: string[], dev: bool, install_path: string, type: string}, versions: array<string, array{dev_requirement: bool, pretty_version?: string, version?: string, aliases?: string[], reference?: string, replaced?: string[], provided?: string[], install_path?: string, type?: string}>}|array{}|null
Severity: Minor
Found in vendor/composer/InstalledVersions.php by phpmd

The class ClassLoader has an overall complexity of 69 which is very high. The configured complexity threshold is 50.
Open

class ClassLoader
{
    /** @var ?string */
    private $vendorDir;
Severity: Minor
Found in vendor/composer/ClassLoader.php by phpmd

File ClassLoader.php has 276 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/*
 * This file is part of Composer.
 *
Severity: Minor
Found in vendor/composer/ClassLoader.php - About 2 hrs to fix

    ClassLoader has 23 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class ClassLoader
{
    /** @var ?string */
    private $vendorDir;
    Severity: Minor
    Found in vendor/composer/ClassLoader.php - About 2 hrs to fix

      Function getInstalled has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

          private static function getInstalled()
    {
        if (null === self::$canGetVendors) {
            self::$canGetVendors = method_exists('Composer\Autoload\ClassLoader', 'getRegisteredLoaders');
        }
      Severity: Minor
      Found in vendor/composer/InstalledVersions.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method findFileWithExtension has 48 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function findFileWithExtension($class, $ext)
    {
        // PSR-4 lookup
        $logicalPathPsr4 = strtr($class, '\\', DIRECTORY_SEPARATOR) . $ext;
      Severity: Minor
      Found in vendor/composer/ClassLoader.php - About 1 hr to fix

        Avoid excessively long class names like ComposerAutoloaderInite5eca23334d547f58d55dd3321eace6e. Keep class name length under 40.
        Open

        class ComposerAutoloaderInite5eca23334d547f58d55dd3321eace6e
{
    private static $loader;

    public static function loadClassLoader($class)
        Severity: Minor
        Found in vendor/composer/autoload_real.php by phpmd

        LongClassName

        Since: 2.9

        Detects when classes or interfaces are declared with excessively long names.

        Example

        class ATooLongClassNameThatHintsAtADesignProblem {

}

interface ATooLongInterfaceNameThatHintsAtADesignProblem {

}

        Source https://phpmd.org/rules/naming.html#longclassname

        Avoid excessively long variable names like $verticalHeaderSeparator. Keep variable name length under 20.
        Open

            public static $verticalHeaderSeparator   = '+';
        Severity: Minor
        Found in lib/ShellTablePrinter.php by phpmd

        LongVariable

        Since: 0.2

        Detects when a field, formal or local variable is declared with a long name.

        Example

        class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

        Source https://phpmd.org/rules/naming.html#longvariable

        Avoid excessively long variable names like $defaultVerticalInnerSign. Keep variable name length under 20.
        Open

            protected static $defaultVerticalInnerSign = '+';
        Severity: Minor
        Found in lib/TableStyle.php by phpmd

        LongVariable

        Since: 0.2

        Detects when a field, formal or local variable is declared with a long name.

        Example

        class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

        Source https://phpmd.org/rules/naming.html#longvariable

        Avoid excessively long variable names like $verticalHeaderSeparator. Keep variable name length under 20.
        Open

            public static $verticalHeaderSeparator   = '+';
        Severity: Minor
        Found in lib/TableStyle.php by phpmd

        LongVariable

        Since: 0.2

        Detects when a field, formal or local variable is declared with a long name.

        Example

        class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

        Source https://phpmd.org/rules/naming.html#longvariable

        Avoid excessively long variable names like $verticalInnerSeparator. Keep variable name length under 20.
        Open

            public static $verticalInnerSeparator   = '+';
        Severity: Minor
        Found in lib/TableStyle.php by phpmd

        LongVariable

        Since: 0.2

        Detects when a field, formal or local variable is declared with a long name.

        Example

        class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

        Source https://phpmd.org/rules/naming.html#longvariable

        Avoid excessively long variable names like $defaultVerticalInnerSign. Keep variable name length under 20.
        Open

            protected static $defaultVerticalInnerSign = '+';
        Severity: Minor
        Found in lib/ShellTablePrinter.php by phpmd

        LongVariable

        Since: 0.2

        Detects when a field, formal or local variable is declared with a long name.

        Example

        class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

        Source https://phpmd.org/rules/naming.html#longvariable

        Avoid excessively long variable names like $verticalInnerSeparator. Keep variable name length under 20.
        Open

            public static $verticalInnerSeparator   = '+';
        Severity: Minor
        Found in lib/ShellTablePrinter.php by phpmd

        LongVariable

        Since: 0.2

        Detects when a field, formal or local variable is declared with a long name.

        Example

        class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

        Source https://phpmd.org/rules/naming.html#longvariable

        Avoid excessively long variable names like $defaultHorizontalSign. Keep variable name length under 20.
        Open

            protected static $defaultHorizontalSign = '-';
        Severity: Minor
        Found in lib/ShellTablePrinter.php by phpmd

        LongVariable

        Since: 0.2

        Detects when a field, formal or local variable is declared with a long name.

        Example

        class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

        Source https://phpmd.org/rules/naming.html#longvariable

        Avoid excessively long variable names like $classMapAuthoritative. Keep variable name length under 20.
        Open

            private $classMapAuthoritative = false;
        Severity: Minor
        Found in vendor/composer/ClassLoader.php by phpmd

        LongVariable

        Since: 0.2

        Detects when a field, formal or local variable is declared with a long name.

        Example

        class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

        Source https://phpmd.org/rules/naming.html#longvariable

        Avoid excessively long class names like ComposerStaticInite5eca23334d547f58d55dd3321eace6e. Keep class name length under 40.
        Open

        class ComposerStaticInite5eca23334d547f58d55dd3321eace6e
{
    public static $prefixLengthsPsr4 = array (
        'K' => 
        array (
        Severity: Minor
        Found in vendor/composer/autoload_static.php by phpmd

        LongClassName

        Since: 2.9

        Detects when classes or interfaces are declared with excessively long names.

        Example

        class ATooLongClassNameThatHintsAtADesignProblem {

}

interface ATooLongInterfaceNameThatHintsAtADesignProblem {

}

        Source https://phpmd.org/rules/naming.html#longclassname

        Avoid excessively long variable names like $classMapAuthoritative. Keep variable name length under 20.
        Open

            public function setClassMapAuthoritative($classMapAuthoritative)
        Severity: Minor
        Found in vendor/composer/ClassLoader.php by phpmd

        LongVariable

        Since: 0.2

        Detects when a field, formal or local variable is declared with a long name.

        Example

        class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

        Source https://phpmd.org/rules/naming.html#longvariable

        Severity
        Category
        Status
        Source
        Language