kristuff/patabase

View on GitHub

Showing 24 of 24 total issues

Function sqlColumns has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

    private function sqlColumns(): string
    {
        $result = array();
        foreach ($this->columns as $col){

Severity: Minor
Found in lib/Query/CreateTable.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

SelectBase has 26 functions (exceeds 20 allowed). Consider refactoring.
Open

abstract class SelectBase extends QueryBuilder
{

    /**
     * Use DISTINCT or not?
Severity: Minor
Found in lib/Query/SelectBase.php - About 3 hrs to fix

    DatabaseDriver has 26 functions (exceeds 20 allowed). Consider refactoring.
    Open

    abstract class DatabaseDriver
    {
        /**
         * PDO connection
         *
    Severity: Minor
    Found in lib/Driver/DatabaseDriver.php - About 3 hrs to fix

      Method sqlColumns has 68 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function sqlColumns(): string
          {
              $result = array();
              foreach ($this->columns as $col){
      
      
      Severity: Major
      Found in lib/Query/CreateTable.php - About 2 hrs to fix

        Function sql has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

            public function sql(): string
            {
                $sql = '';
                if (!empty($this->conditions)) {
                    $sql = ' '. $this->sqlBase  .' ';  // start the SQL WHERE or HAVING clause
        Severity: Minor
        Found in lib/Query/QueryFilter.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method sql has 44 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function sql(): string
            {
                $sql = '';
                if (!empty($this->conditions)) {
                    $sql = ' '. $this->sqlBase  .' ';  // start the SQL WHERE or HAVING clause
        Severity: Minor
        Found in lib/Query/QueryFilter.php - About 1 hr to fix

          Method sql has 37 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function sql(): string
              {
                  $topQuery = $this->topQuery ?: $this;  
                  $sqlJoins = empty($this->joins) ? '' : implode(' ', $this->joins) ; 
                  $sqlFromTable =  'FROM '. $this->escape($this->fromTable);
          Severity: Minor
          Found in lib/Query/Select.php - About 1 hr to fix

            Method sqlColumns has 36 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private function sqlColumns(): string
                {
                    // no columns givens select all (SELECT *)
                    if (!count($this->columns) > 0 ) {
                        return '*';   
            Severity: Minor
            Found in lib/Query/Select.php - About 1 hr to fix

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                  public function rightJoin(string $externalTable, string $externalColumn, string $localTable, string $localColumn)
                  {
                      $this->joins[] = sprintf(
                          'RIGHT OUTER JOIN %s ON %s=%s',
                          $this->driver->escape($externalTable),
              Severity: Major
              Found in lib/Query/SelectBase.php and 3 other locations - About 1 hr to fix
              lib/Query/SelectBase.php on lines 307..316
              lib/Query/SelectBase.php on lines 351..360
              lib/Query/SelectBase.php on lines 373..382

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 106.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                  public function fullJoin(string $externalTable, string $externalColumn, string $localTable, string $localColumn)
                  {
                      $this->joins[] = sprintf(
                          'FULL OUTER JOIN %s ON %s=%s',
                          $this->driver->escape($externalTable),
              Severity: Major
              Found in lib/Query/SelectBase.php and 3 other locations - About 1 hr to fix
              lib/Query/SelectBase.php on lines 307..316
              lib/Query/SelectBase.php on lines 329..338
              lib/Query/SelectBase.php on lines 373..382

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 106.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                  public function innerJoin(string $externalTable, string $externalColumn, string $localTable, string $localColumn)
                  {
                      $this->joins[] = sprintf(
                          'INNER JOIN %s ON %s=%s',
                          $this->driver->escape($externalTable),
              Severity: Major
              Found in lib/Query/SelectBase.php and 3 other locations - About 1 hr to fix
              lib/Query/SelectBase.php on lines 307..316
              lib/Query/SelectBase.php on lines 329..338
              lib/Query/SelectBase.php on lines 351..360

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 106.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                  public function leftJoin(string $externalTable, string $externalColumn, string $localTable, string $localColumn)
                  {
                      $this->joins[] = sprintf(
                          'LEFT OUTER JOIN %s ON %s=%s',
                          $this->driver->escape($externalTable),
              Severity: Major
              Found in lib/Query/SelectBase.php and 3 other locations - About 1 hr to fix
              lib/Query/SelectBase.php on lines 329..338
              lib/Query/SelectBase.php on lines 351..360
              lib/Query/SelectBase.php on lines 373..382

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 106.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function sqlColumns has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function sqlColumns(): string
                  {
                      // no columns givens select all (SELECT *)
                      if (!count($this->columns) > 0 ) {
                          return '*';   
              Severity: Minor
              Found in lib/Query/Select.php - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method fk has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public function fk(string $fkName, string $srcColumn, string $refTable, string $refColumn, ?string $onUpdate = 'CASCADE', ?string $onDelete = 'RESTRICT')
              Severity: Minor
              Found in lib/Query/CreateTable.php - About 45 mins to fix

                Function bindValues has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                    protected function bindValues(): void
                    {
                        // pdo statement may be not set at this stage if prepare failed
                        if (isset($this->pdoStatement)) {
                
                
                Severity: Minor
                Found in lib/Query/QueryBuilder.php - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method addForeignKey has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    public function addForeignKey(string $fkName, string $srcTable, string $srcColumn, string $refTable, string $refColumn): bool
                Severity: Minor
                Found in lib/Driver/Postgres/PostgresDriver.php - About 35 mins to fix

                  Method addForeignKey has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      public function addForeignKey(string $fkName, string $srcTable, string $srcColumn, string $refTable, string $refColumn): bool
                  Severity: Minor
                  Found in lib/Database.php - About 35 mins to fix

                    Method addForeignKey has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        abstract public function addForeignKey(string $fkName, string $srcTable, string $srcColumn, string $refTable, string $refColumn) : bool;
                    Severity: Minor
                    Found in lib/Driver/DatabaseDriver.php - About 35 mins to fix

                      Method addCondition has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          protected function addCondition(string $type, string $sql, ?string $column, $value, ?string $operator = ''): void
                      Severity: Minor
                      Found in lib/Query/QueryFilter.php - About 35 mins to fix

                        Method addForeignKey has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            public function addForeignKey(string $fkName, string $srcTable, string $srcColumn, string $refTable, string $refColumn): bool
                        Severity: Minor
                        Found in lib/Driver/Sqlite/SqliteDriver.php - About 35 mins to fix
                          Severity
                          Category
                          Status
                          Source
                          Language