kylekatarnls/business-time

View on GitHub
src/BusinessTime/MixinBase.php

Summary

Maintainability
A
3 hrs
Test Coverage
A
100%

Method enable has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function enable($carbonClass = null, $defaultOpeningHours = null)
    {
        if ($carbonClass === null) {
            return static function () {
                return true;
Severity: Minor
Found in src/BusinessTime/MixinBase.php - About 1 hr to fix

    Consider simplifying this complex logical expression.
    Open

                        if ((
                            (!$mode || $mode === $mixin::LOCAL_MODE) &&
                            ($date = end(static::$macroContextStack)) &&
                            ($hours = $mixin->getOpeningHours($mixin::LOCAL_MODE, $date))
                        ) ||
    Severity: Major
    Found in src/BusinessTime/MixinBase.php - About 1 hr to fix

      Function enable has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function enable($carbonClass = null, $defaultOpeningHours = null)
          {
              if ($carbonClass === null) {
                  return static function () {
                      return true;
      Severity: Minor
      Found in src/BusinessTime/MixinBase.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getOpeningHours has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getOpeningHours($mode = null, $context = null)
          {
              switch ($mode) {
                  case static::GLOBAL_MODE:
                      return $this->openingHours;
      Severity: Minor
      Found in src/BusinessTime/MixinBase.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      The method getOpeningHours() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
      Open

          public function getOpeningHours($mode = null, $context = null)
          {
              switch ($mode) {
                  case static::GLOBAL_MODE:
                      return $this->openingHours;
      Severity: Minor
      Found in src/BusinessTime/MixinBase.php by phpmd

      CyclomaticComplexity

      Since: 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example

      // Cyclomatic Complexity = 11
      class Foo {
      1   public function example() {
      2       if ($a == $b) {
      3           if ($a1 == $b1) {
                      fiddle();
      4           } elseif ($a2 == $b2) {
                      fiddle();
                  } else {
                      fiddle();
                  }
      5       } elseif ($c == $d) {
      6           while ($c == $d) {
                      fiddle();
                  }
      7        } elseif ($e == $f) {
      8           for ($n = 0; $n < $h; $n++) {
                      fiddle();
                  }
              } else {
                  switch ($z) {
      9               case 1:
                          fiddle();
                          break;
      10              case 2:
                          fiddle();
                          break;
      11              case 3:
                          fiddle();
                          break;
                      default:
                          fiddle();
                          break;
                  }
              }
          }
      }

      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

      Avoid using static access to class 'BusinessTime\Normalizer' in method 'convertOpeningHours'.
      Open

                              : Normalizer::normalizeDay($key);
      Severity: Minor
      Found in src/BusinessTime/MixinBase.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid assigning values to variables in if clauses and the like (line '310', column '26').
      Open

          public function getOpeningHours($mode = null, $context = null)
          {
              switch ($mode) {
                  case static::GLOBAL_MODE:
                      return $this->openingHours;
      Severity: Minor
      Found in src/BusinessTime/MixinBase.php by phpmd

      IfStatementAssignment

      Since: 2.7.0

      Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

      Example

      class Foo
      {
          public function bar($flag)
          {
              if ($foo = 'bar') { // possible typo
                  // ...
              }
              if ($baz = 0) { // always false
                  // ...
              }
          }
      }

      Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

      Avoid assigning values to variables in if clauses and the like (line '309', column '26').
      Open

          public function getOpeningHours($mode = null, $context = null)
          {
              switch ($mode) {
                  case static::GLOBAL_MODE:
                      return $this->openingHours;
      Severity: Minor
      Found in src/BusinessTime/MixinBase.php by phpmd

      IfStatementAssignment

      Since: 2.7.0

      Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

      Example

      class Foo
      {
          public function bar($flag)
          {
              if ($foo = 'bar') { // possible typo
                  // ...
              }
              if ($baz = 0) { // always false
                  // ...
              }
          }
      }

      Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

      Avoid assigning values to variables in if clauses and the like (line '313', column '29').
      Open

          public function getOpeningHours($mode = null, $context = null)
          {
              switch ($mode) {
                  case static::GLOBAL_MODE:
                      return $this->openingHours;
      Severity: Minor
      Found in src/BusinessTime/MixinBase.php by phpmd

      IfStatementAssignment

      Since: 2.7.0

      Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

      Example

      class Foo
      {
          public function bar($flag)
          {
              if ($foo = 'bar') { // possible typo
                  // ...
              }
              if ($baz = 0) { // always false
                  // ...
              }
          }
      }

      Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

      Avoid using static access to class '\Spatie\OpeningHours\OpeningHours' in method 'convertOpeningHours'.
      Open

                      return OpeningHours::create($hours);
      Severity: Minor
      Found in src/BusinessTime/MixinBase.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class 'BusinessTime\Normalizer' in method 'normalizeDay'.
      Open

                  return Normalizer::normalizeDay($day, static::$days);
      Severity: Minor
      Found in src/BusinessTime/MixinBase.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      There are no issues that match your filters.

      Category
      Status